Bug 232246 - devel/py-oslo.messaging: Fix for the RabbitMQ driver when used with Python 3+
Summary: devel/py-oslo.messaging: Fix for the RabbitMQ driver when used with Python 3+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 232244 232245
  Show dependency treegraph
 
Reported: 2018-10-14 13:07 UTC by Kai Knoblich
Modified: 2018-10-16 20:07 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
py-oslo.messaging-fix-rabbitmq-py36.patch (1.71 KB, patch)
2018-10-14 13:07 UTC, Kai Knoblich
kai: maintainer-approval? (sunpoet)
Details | Diff
py-oslo.messaging-fix-rabbitmq-py36.log (4.80 KB, text/plain)
2018-10-14 13:09 UTC, Kai Knoblich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer 2018-10-14 13:07:22 UTC
Created attachment 198134 [details]
py-oslo.messaging-fix-rabbitmq-py36.patch

Hello,

attached is the patch that fixes the RabbitMQ driver (= oslo_messaging/_drivers/impl_rabbit.py) on FreeBSD when used as Python 3+ package.

Without the patch the RabbitMQ messaging driver tries to use a timeout for a newly created TCP socket but will fail shortly afterwards because FreeBSD doesn't implement the TCP_USER_TIMEOUT option (RFC 5482) (yet?).

This leads into spawning multiple embryonic TCP connections that are never going into the ESTABLISHED state. 

The issue has been discovered during runtime-tests of the misc/py-cinder port in conjunction with a RabbitMQ messaging server. Please see also the attached logfile for further details.

QA:
~~~
- poudriere (10.4-, 11.2-RELEASE, 12.0-ALPHA9 amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK
Comment 1 Kai Knoblich freebsd_committer 2018-10-14 13:09:02 UTC
Created attachment 198135 [details]
py-oslo.messaging-fix-rabbitmq-py36.log
Comment 2 commit-hook freebsd_committer 2018-10-16 20:06:36 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Oct 16 20:05:52 UTC 2018
New revision: 482259
URL: https://svnweb.freebsd.org/changeset/ports/482259

Log:
  Fix RabbitMQ connections with Python 3.x

  - Bump PORTREVISION for package change

  PR:		232246
  Submitted by:	Kai <freebsd_ports@k-worx.org>

Changes:
  head/devel/py-oslo.messaging/Makefile
  head/devel/py-oslo.messaging/files/
  head/devel/py-oslo.messaging/files/patch-oslo_messaging-_drivers-impl_rabbit.py
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-10-16 20:07:24 UTC
Committed. Thanks!