Created attachment 198137 [details] patch Upgrade to new version 3.25.2 (https://sqlite.org/releaselog/3_25_2.html) Add ICU flavor (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231770)
Created attachment 198138 [details] build log
Created attachment 198139 [details] portlint log
I do not understand the rationale behind adding flavors. pkg will not allow you to use sqlite3-icu, instead of sqlite3, so the only way you can use it is by manually building all dependencies, and in that case, you might as well change the option.
Good afternoon- The icu flavor is my fault. I am working to provide perl sqlite support with ICU for the logitechmediaserver port. In my testing on my machine, I was able to have the icu flavor of the p5-DBD-SQLite port list the sqlite3@icu as the dependency: `icu_LIB_DEPENDS= libsqlite3.so:databases/sqlite3@icu` How (other than the suggested method) can a port guarantee a particular option is enabled on one of its dependencies?
(In reply to Mathieu Arnold from comment #3) Oh! Do you mean that full flavor support would require updating all the dependencies for every port that depends on sqlite3? That is, add sqlite3-icu as an acceptable source of the required shared library?
New version 3.25.3 is released. Firefox 65 will require it. https://www.sqlite.org/releaselog/3_25_3.html