Bug 232248 - databases/sqlite3: Update to 3.25.2
Summary: databases/sqlite3: Update to 3.25.2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks: 231770
  Show dependency treegraph
 
Reported: 2018-10-14 15:05 UTC by Pavel Volkov
Modified: 2018-12-04 18:03 UTC (History)
4 users (show)

See Also:


Attachments
patch (2.38 KB, patch)
2018-10-14 15:05 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
build log (25.98 KB, text/plain)
2018-10-14 15:06 UTC, Pavel Volkov
no flags Details
portlint log (26.98 KB, text/plain)
2018-10-14 15:07 UTC, Pavel Volkov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2018-10-14 15:05:04 UTC
Created attachment 198137 [details]
patch

Upgrade to new version 3.25.2 (https://sqlite.org/releaselog/3_25_2.html)
Add ICU flavor (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231770)
Comment 1 Pavel Volkov 2018-10-14 15:06:30 UTC
Created attachment 198138 [details]
build log
Comment 2 Pavel Volkov 2018-10-14 15:07:01 UTC
Created attachment 198139 [details]
portlint log
Comment 3 Mathieu Arnold freebsd_committer 2018-10-14 19:10:42 UTC
I do not understand the rationale behind adding flavors.

pkg will not allow you to use sqlite3-icu, instead of sqlite3, so the only way you can use it is by manually building all dependencies, and in that case, you might as well change the option.
Comment 4 Matt 2018-10-14 19:38:25 UTC
Good afternoon-

The icu flavor is my fault. I am working to provide perl sqlite support with ICU for the logitechmediaserver port.

In my testing on my machine, I was able to have the icu flavor of the p5-DBD-SQLite port list the sqlite3@icu as the dependency: 
`icu_LIB_DEPENDS=        libsqlite3.so:databases/sqlite3@icu`

How (other than the suggested method) can a port guarantee a particular option is enabled on one of its dependencies?
Comment 5 Matt 2018-10-15 15:06:01 UTC
(In reply to Mathieu Arnold from comment #3)
Oh! Do you mean that full flavor support would require updating all the dependencies for every port that depends on sqlite3? That is, add sqlite3-icu as an acceptable source of the required shared library?
Comment 6 Charlie Li 2018-11-16 00:24:56 UTC
New version 3.25.3 is released. Firefox 65 will require it.

https://www.sqlite.org/releaselog/3_25_3.html