Bug 232323 - graphics/glfw: make WAYLAND and X11 conflicting
Summary: graphics/glfw: make WAYLAND and X11 conflicting
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch, patch-ready
Depends on:
Blocks: 226605 227509
  Show dependency tree / graph
 
Reported: 2018-10-16 14:13 UTC by Jan Beich
Modified: 2018-10-20 21:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nc)

Attachments
v1 (1.26 KB, patch)
2018-10-16 14:13 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-10-16 14:13:15 UTC 
Created attachment 198212 [details]
v1

OPTIONS_SET+=WAYLAND breaking existing usage (see bug 227509 comment 9) is a POLA. Let's add a safety belt which Mir (if ever ported) can also take advantage of. Based on multimedia/kodi-devel.

Flavorizing isn't an option until support for variable dependencies arrives. For one, pkg upgrade will replace glfw@wayland with glfw@x11 unless no consumers have been installed yet or installed consumers expose their own @wayland flavor that depends on glfw@wayland.

Build logs:
- https://ptpb.pw/QbYv (WAYLAND=off X11=on)
- https://ptpb.pw/l6ug (WAYLAND=on  X11=off)
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-20 18:37:48 UTC 
LGTM.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-20 21:39:13 UTC 
A commit references this bug:

Author: jbeich
Date: Sat Oct 20 21:39:09 UTC 2018
New revision: 482624
URL: https://svnweb.freebsd.org/changeset/ports/482624

Log:
  graphics/glfw: prevent enabling WAYLAND without disabling X11

  PR:		232323
  Reviewed by:	tobik
  Approved by:	portmgr blanket

Changes:
  head/graphics/glfw/Makefile