Bug 232353 - x11-drivers/xf86-video-intel: update to 2.99.917.20180906 (snapshot)
Summary: x11-drivers/xf86-video-intel: update to 2.99.917.20180906 (snapshot)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL: https://cgit.freedesktop.org/xorg/dri...
Keywords: patch, patch-ready
Depends on: 228407
Blocks: 233902
  Show dependency treegraph
 
Reported: 2018-10-17 13:20 UTC by Jan Beich
Modified: 2018-12-10 03:35 UTC (History)
4 users (show)

See Also:
zeising: maintainer-feedback+
jbeich: merge-quarterly?


Attachments
v1 (2.12 KB, patch)
2018-10-17 13:20 UTC, Jan Beich
jbeich: maintainer-approval? (x11)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-10-17 13:20:40 UTC
Created attachment 198267 [details]
v1

Tested on Intel HD530 (aka Skylake GT2) + drm-stable-kmod (Linux 4.9) + i965/anv (DRI3) + intel (SNA, DRI3) via mpv (EGL + VAAPI), ppsspp (vulkan), rpcs3 (OpenGL 4.3+), firefox (WebRender).

Build logs:
10.4 i386:  https://ptpb.pw/BAtQ
12.0 amd64: https://ptpb.pw/bNvd
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-10-19 23:09:45 UTC
Carlos or Kevin, can you check for regressions on FreeBSD < 11.2 (or drm-legacy-kmod)? To save time test together with bug 230298.
Comment 2 rkoberman 2018-10-20 00:09:07 UTC
(In reply to Jan Beich from comment #1)
To clarify, do I need to go back to drm-legacy or is testing with drm-stable, shich I now run, OK.

As to the patch, I am assuming that you refer to D16571.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2018-10-20 00:14:48 UTC
(In reply to rkoberman from comment #2)
> To clarify, do I need to go back to drm-legacy or is testing with drm-stable, shich I now run, OK.

Both if possible. drm-stable-kmod has more users and is based on more recent Linux kernel, so less likely to regress.

> As to the patch, I am assuming that you refer to D16571.

Correct.
Comment 4 rkoberman 2018-10-20 17:23:49 UTC
Basic tests on my Sandy Bridge system shows no issues with the combination of mesa and xf86-videoo-intel updates while running without drm-kmod. Kernel module is i915kms. That is as close to drm-legacy-kmd as I can get in 11.2-STABLE. glxgears runs at about 5500 FPS.

I will move to running the updated mesa and video-intel driver with drm-stable-kmod 

I should mention that I had to delete graphics/mesa-dri/files/patch-llvm7 to get the mesa ports to build. I suspect this is not a real issue.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2018-10-20 17:46:04 UTC
(In reply to rkoberman from comment #4)
> glxgears runs at about 5500 FPS.

glxgears should run at 60FPS with direct rendering unless VSYNC is broken or forcefully disabled (e.g., vblank_mode=0 in ~/.drirc or environment).
Are you sure the behavior *before* Mesa update was the same? If not maybe show output when running with LIBGL_DEBUG=verbose 

> ... delete graphics/mesa-dri/files/patch-llvm7 to get the mesa ports to build.

See -E flag in patch(1). I often do "patch -Efsp0 -i /path/to/whatever.diff" to mimic other commands that are silent unless something has gone wrong. If you still have rejects maybe the tree is out of date or other applied patches conflict.
Comment 6 rkoberman 2018-10-20 20:58:45 UTC
(In reply to Jan Beich from comment #5)
Since I want to make sure acceleration is working, I run it without vsync. With vsync, as you state, I get 60 FPS.

The only issue was the presence of the llvm7 patch. I assumed that this was a -E issue and that's why I figured it was not relevant. I just thought I should mention it. Everything else was clean for both mesa and the video driver.

I will try it with drm-stable-kmod re-installed shortly.
Comment 7 rkoberman 2018-10-20 21:17:05 UTC
(In reply to Jan Beich from comment #5)
Everything is now running fine with drm-stable-kmod, so it works on 11.2-STABLE with either the default kmod or with drm-stable-kmod. A bit surprisingly, the drm-stable-kmod version runs aout 400-500 FPS slower than the legacy drm. Of course, still 60.12 FPS with vsync enabled.

So, everything looks good with both updates.
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-10-28 20:20:58 UTC
A commit references this bug:

Author: zeising
Date: Sun Oct 28 20:20:28 UTC 2018
New revision: 483350
URL: https://svnweb.freebsd.org/changeset/ports/483350

Log:
  x11-drivers/xf86-video-intel: Update snapshot

  Update the snapshot of the intel DDX driver for xorg.
  Upstream has stopped doing releases of this, but there are still code
  updates, so we have used snapshots of the upstream source repo for some
  time.

  PR:		232353
  Submitted by:	jbeich
  Tested by:	jbeic, rkoberman@gmail.com

Changes:
  head/x11-drivers/xf86-video-intel/Makefile
  head/x11-drivers/xf86-video-intel/distinfo
Comment 9 Niclas Zeising freebsd_committer freebsd_triage 2018-10-28 20:22:06 UTC
Committed, thank you!
Comment 10 Jan Beich freebsd_committer freebsd_triage 2018-12-10 02:41:59 UTC
Can you MFH to 2018Q4? modesetting(4x) is currently useless on CoffeeLake (or newer) due to old xorg-server version in the tree.

For one, https://lists.freebsd.org/pipermail/freebsd-x11/2018-December/022265.html requires this update.