Bug 232512 - www/firefox-esr: 60.3.0,1 build fails phase patch
Summary: www/firefox-esr: 60.3.0,1 build fails phase patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-21 19:54 UTC by p5B2EA84B3
Modified: 2018-10-22 19:53 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback+

Attachments
Poudriere build log (11.42 KB, text/plain)
2018-10-21 19:54 UTC, p5B2EA84B3 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description p5B2EA84B3 2018-10-21 19:54:20 UTC 
Created attachment 198446 [details]
Poudriere build log

firefox-esr-60.3.0,1 build fails during phase patch. See attachment for Poudriere log file.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-10-21 20:32:56 UTC 
Seems the patch patch-bug1474265 ist forgotten to remove.

patch:
@ -142,7 +142,7 @@ DBusRemoteClient::GetRemoteDestinationName(const char *aProgram,
       (bool (*)(const char *, DBusError *))
       dlsym(RTLD_DEFAULT, "dbus_validate_bus_name");
     if (!sDBusValidateBusName) {
-      return false
+      return false;


source-code:
  141     static auto sDBusValidateBusName =
    142       (bool (*)(const char *, DBusError *))
    143       dlsym(RTLD_DEFAULT, "dbus_validate_bus_name");
    144     if (!sDBusValidateBusName) {
    145       return false;


It is already in the unpatched source-code file.
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-10-21 20:56:07 UTC 
The patch eems is erronousely added. The patch seems needed for firefox-63.0_1,1 and  thunderbird 60.2.1_1 but not for firefox-esr.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-21 21:11:20 UTC 
Actually invite maintainer to the bug...
Comment 4 Jan Beich freebsd_committer freebsd_triage 2018-10-21 22:01:07 UTC 
https://svnweb.freebsd.org/changeset/ports/482725 (has bogus PR number)

Ugh, I've incorrectly assumed thunderbird and firefox-esr track the same esr60 release and forgot to check at least with "make clean patch". Thanks for reporting but it looks like pkg-fallout@ was also quick to grant a pointy hat.
Comment 5 p5B2EA84B3 2018-10-22 09:38:42 UTC 
Removing just the patch seems not be sufficient for Poudriere to start a building for a port that has no altered version string.
A new build is not possible.
Comment 6 p5B2EA84B3 2018-10-22 09:40:41 UTC 
PR:		1474265

is wrong as this was the number of the patch, not the PR
Comment 7 Jan Beich freebsd_committer freebsd_triage 2018-10-22 12:37:46 UTC 
(In reply to p5B2E9A8F from comment #5)
> Removing just the patch seems not be sufficient for Poudriere
> to start a building for a port that has no altered version string.

If you already have package built don't waste cycles. ;)

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision

  Examples of changes which do not require a PORTREVISION bump:
  - Build fixes which cause a package to become compilable where it was previously failing
Comment 8 p5B2EA84B3 2018-10-22 19:53:52 UTC 
Thank you. There was an error unrelated to the port. Sorry for that.