Bug 232805 - net/openslp: fix build on stable/12 with crypto option enabled
Summary: net/openslp: fix build on stable/12 with crypto option enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-30 08:30 UTC by Oleg Sidorkin
Modified: 2018-11-02 09:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
fix for net/openslp + openssl 1.1 build (1.24 KB, patch)
2018-10-30 08:30 UTC, Oleg Sidorkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2018-10-30 08:30:35 UTC
Created attachment 198763 [details]
fix for net/openslp + openssl 1.1 build

Some functions were hidden in openssl 1.1. Use openssl function instead of homegrown implementation.

Error log:

# make MAKE_JOBS_UNSAFE=yes
===>  Building for openslp-2.0.0_1
/usr/bin/make  all-recursive
Making all in common
/bin/sh ../libtool --tag=CC    --mode=compile cc -DHAVE_CONFIG_H -I. -I..    -DHAVE_STRNCASECMP  -O2 -pipe -march=haswell  -fstack-protector -fno-strict-aliasing  -Wall -MT slp_crypto.lo -MD -MP -MF .deps/slp_crypto.Tpo -c -o slp_crypto.lo slp_crypto.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -DHAVE_STRNCASECMP -O2 -pipe -march=haswell -fstack-protector -fno-strict-aliasing -Wall -MT slp_crypto.lo -MD -MP -MF .deps/slp_crypto.Tpo -c slp_crypto.c  -fPIC -DPIC -o .libs/slp_crypto.o
slp_crypto.c:91:13: error: incomplete definition of type 'struct dsa_st'
      result->p = BN_dup(dsa->p);
      ~~~~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:91:29: error: incomplete definition of type 'struct dsa_st'
      result->p = BN_dup(dsa->p);
                         ~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:92:13: error: incomplete definition of type 'struct dsa_st'
      result->q = BN_dup(dsa->q);
      ~~~~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:92:29: error: incomplete definition of type 'struct dsa_st'
      result->q = BN_dup(dsa->q);
                         ~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:93:13: error: incomplete definition of type 'struct dsa_st'
      result->g = BN_dup(dsa->g);
      ~~~~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:93:29: error: incomplete definition of type 'struct dsa_st'
      result->g = BN_dup(dsa->g);
                         ~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:94:13: error: incomplete definition of type 'struct dsa_st'
      result->priv_key = BN_dup(dsa->priv_key);
      ~~~~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:94:36: error: incomplete definition of type 'struct dsa_st'
      result->priv_key = BN_dup(dsa->priv_key);
                                ~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:95:13: error: incomplete definition of type 'struct dsa_st'
      result->pub_key = BN_dup(dsa->pub_key);
      ~~~~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
slp_crypto.c:95:35: error: incomplete definition of type 'struct dsa_st'
      result->pub_key = BN_dup(dsa->pub_key);
                               ~~~^
/usr/include/openssl/ossl_typ.h:107:16: note: forward declaration of 'struct dsa_st'
typedef struct dsa_st DSA;
               ^
10 errors generated.
*** Error code 1

Stop.
Comment 1 Joe Marcus Clarke freebsd_committer 2018-11-02 09:06:40 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2018-11-02 09:06:55 UTC
A commit references this bug:

Author: marcus
Date: Fri Nov  2 09:06:25 UTC 2018
New revision: 483791
URL: https://svnweb.freebsd.org/changeset/ports/483791

Log:
  Fix the build with OpenSSL 1.1.1.

  PR:		232805
  Submitted by:	osidorkin@gmail.com

Changes:
  head/net/openslp/files/patch-common_slp__crypto.c