Bug 232817 - graphics/eom: fix build with GCC-based architectures
Summary: graphics/eom: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-30 17:20 UTC by Piotr Kubaj
Modified: 2018-11-27 16:33 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (515 bytes, patch)
2018-10-30 17:20 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-30 17:20:50 UTC 
Created attachment 198776 [details]
patch

USES=compiler:c++11-lang is required to build on GCC architectures.

While here, add USES=gnome mate.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Ting-Wei Lan 2018-11-17 07:05:39 UTC 
Do you have the build log? It looks odd for a C project to require C++11.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-11-18 18:07:40 UTC 
(In reply to Ting-Wei Lan from comment #1)

It turns out that our stanza for "c++11-lang" and "c11" do exactly the same thing.  We have generally been testing against the former.  However, I can re-test against the latter.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-11-24 09:11:31 UTC 
A commit references this bug:

Author: linimon
Date: Sat Nov 24 09:11:01 UTC 2018
New revision: 485738
URL: https://svnweb.freebsd.org/changeset/ports/485738

Log:
  Add compiler:c11 to USES to fix build on gcc-based archs.

  PR:		232817
  Submitted by:	Piotr Kubaj
  Reviewed by:	Ting-Wei Lan

Changes:
  head/graphics/eom/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-27 16:33:45 UTC 
A commit references this bug:

Author: linimon
Date: Tue Nov 27 16:32:44 UTC 2018
New revision: 486023
URL: https://svnweb.freebsd.org/changeset/ports/486023

Log:
  Previous patch did not include adding gmake mate to USES.

  PR:		232817
  Reported by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/graphics/eom/Makefile