Bug 232959 - science/dalton fails to build with GCC 8
Summary: science/dalton fails to build with GCC 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 231590
  Show dependency treegraph
 
Reported: 2018-11-04 12:10 UTC by Gerald Pfeifer
Modified: 2018-11-04 18:58 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer 2018-11-04 12:10:16 UTC
We are working to update the default version of GCC in the Ports 
Collection from GCC 7 to GCC 8.  

Alas science/dalton fails to build with that newer compiler which
unfortunately blocks this update.


Cf. http://package22.nyi.freebsd.org/data/112amd64-default-PR231590/2018-10-29_06h48m05s/logs/errors/dalton-2016.2.log

/wrkdirs/usr/ports/science/dalton/work/dalton-130ffaa0613bb3af6cac766fc8183d6df7d68917-130ffaa0613bb3af6cac766fc8183d6df7d68917/DALTON/choles/cc_cholesky.F:832:42:

                CALL CC_PUTCHO(WORK(KCHO1),IDNTC1,NCHORD,IDUMP,
                                          1
Error: Actual argument contains too few elements for dummy argument 'idntc1' (75/200) at (1)
Comment 1 Yuri Victorovich freebsd_committer 2018-11-04 17:05:56 UTC
(In reply to Gerald Pfeifer from comment #0)

Gerald,

You need to create the gfortran (gcc project) bug report, because this seems to be a fortran issue.

Yuri
Comment 2 Yuri Victorovich freebsd_committer 2018-11-04 17:13:20 UTC
The dalton upstream report: https://gitlab.com/dalton/dalton/issues/80
Comment 3 Yuri Victorovich freebsd_committer 2018-11-04 17:15:17 UTC
(In reply to Yuri Victorovich from comment #1)

I'm not sure if this is a fortran bug.

Yuri
Comment 4 Yuri Victorovich freebsd_committer 2018-11-04 18:15:47 UTC
Fixed.
Comment 5 commit-hook freebsd_committer 2018-11-04 18:16:35 UTC
A commit references this bug:

Author: yuri
Date: Sun Nov  4 18:15:36 UTC 2018
New revision: 484118
URL: https://svnweb.freebsd.org/changeset/ports/484118

Log:
  science/dalton: Fix build with GCC8

  Backport the upstream patch that fixed the issue.

  PR:		232959
  Reported by:	gerald

Changes:
  head/science/dalton/Makefile
  head/science/dalton/distinfo
Comment 6 Gerald Pfeifer freebsd_committer 2018-11-04 18:58:41 UTC
(In reply to commit-hook from comment #5)
> Author: yuri
> Date: Sun Nov  4 18:15:36 UTC 2018
> New revision: 484118
> URL: https://svnweb.freebsd.org/changeset/ports/484118
>
> Log:
>  science/dalton: Fix build with GCC8

Thank you, Yuri!