Bug 233008 - net/tcpdump: #includes deprecated sys/capability.h header
Summary: net/tcpdump: #includes deprecated sys/capability.h header
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks: 228878
  Show dependency treegraph
 
Reported: 2018-11-05 23:49 UTC by Ed Maste
Modified: 2018-11-06 17:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2018-11-05 23:49:58 UTC
sys/capability.h will be removed before FreeBSD 13. The (now) correct header to use on all supported (and some unsupported) versions of FreeBSD is sys/capsicum.h. There's no need for autoconf checks etc. to check for both (in the ports tree) but upstream may want to if there's a desire to build on older releases.
Comment 1 Renato Botelho freebsd_committer 2018-11-06 10:50:49 UTC
I'll open a bug in upstream and then add a patch on ports
Comment 2 commit-hook freebsd_committer 2018-11-06 17:18:09 UTC
A commit references this bug:

Author: garga
Date: Tue Nov  6 17:17:33 UTC 2018
New revision: 484310
URL: https://svnweb.freebsd.org/changeset/ports/484310

Log:
  - Do not include deprecated header sys/capability.h [1]
  - Remove unnecessary include of bsd.port.pre.mk
  - Add LICENSE_FILE
  - Fix USES order
  - Bump PORTREVISION

  PR:		233008 [1]
  Reported by:	emaste@ [1]
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/net/tcpdump/Makefile
Comment 3 Renato Botelho freebsd_committer 2018-11-06 17:20:55 UTC
PR submitted to upstream at https://github.com/the-tcpdump-group/tcpdump/pull/715