Bug 233036 - [PATCH] devel/jfrog-cli: update to 1.20.2
Summary: [PATCH] devel/jfrog-cli: update to 1.20.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-06 18:48 UTC by Antoine Levy-Lambert
Modified: 2018-11-09 19:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
patch to upgrade jfrog to 1.20.2 (2.15 KB, patch)
2018-11-06 18:48 UTC, Antoine Levy-Lambert 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Levy-Lambert 2018-11-06 18:48:13 UTC 
Created attachment 199021 [details]
patch to upgrade jfrog to 1.20.2

Upgrade jfrog to 1.20.2
Comment 1 Nathan 2018-11-07 00:24:29 UTC 
Comment on attachment 199021 [details]
patch to upgrade jfrog to 1.20.2

{MV} ${WRKSRC}/jfrog-cli use ${INSTALL_SCRIPT} or ${INSTALL_PROGRAM}(according to type of executable
Comment 2 Antoine Levy-Lambert 2018-11-07 23:38:26 UTC 
Hello Nathan,

semantically these commands

post-extract:
	@${MV} ${WRKSRC}/vendor/ ${WRKSRC}/src
	@${MKDIR} ${WRKSRC}/src/github.com/jfrogdev/jfrog-cli-go
	@${MV} ${WRKSRC}/jfrog-cli ${WRKSRC}/jfrog-client ${WRKSRC}/src/github.com/jfrogdev/jfrog-cli-go

are not installation commands, it is a reordering of the source tree prior to building.

Does it make sense to use ${INSTALL_SCRIPT} instead ?
The second ${MV} moves two folders to one destination.
Is ${INSTALL_SCRIPT} copying ? or moving ?
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-11-09 16:38:33 UTC 
Committed, thanks!
Comment 4 Antoine Levy-Lambert 2018-11-09 19:23:31 UTC 
Great, thanks.