Bug 233443 - lang/gcc6: Fix sed expression in classpath
Summary: lang/gcc6: Fix sed expression in classpath
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2018-11-23 15:58 UTC by Kyle Evans
Modified: 2019-02-19 22:25 UTC (History)
1 user (show)

See Also:
gerald: maintainer-feedback+


Attachments
svn(1) diff against lang/gcc6 (1.28 KB, patch)
2018-11-23 15:58 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2018-11-23 15:58:05 UTC
Created attachment 199484 [details]
svn(1) diff against lang/gcc6

Hi,

This same patch has been submitted to java/classpath in bug #233440, excerpt:

scripts/check__jni__methods.sh has an expression using an escape of an ordinary character, '\J'. This will be disallowed in future versions of our regex(3) as we ease our way into GNU extensions in libregex. Attached patch simply patches out the escape, which should yield the same result with gsed and be upstreamable.

Thanks,

Kyle Evans
Comment 1 Gerald Pfeifer freebsd_committer freebsd_triage 2018-11-25 21:26:13 UTC
Thanks for tracking this down and providing this patch, Kyle!

Would you like to commit this (in which case Approved by: gerald),
or would you prefer me to do so?
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2019-02-19 21:28:49 UTC
(In reply to Gerald Pfeifer from comment #1)
> Would you like to commit this (in which case Approved by: gerald),
> or would you prefer me to do so?

Since I haven't seen a response since then and there was a good patch
provided, I'm doing another, final test now and will apply this on your
behalf.  Thank you for the report and the patch!

(Note that I'll slightly be changing the filename of the patch to match
the others in this port.)
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-02-19 22:10:10 UTC
A commit references this bug:

Author: gerald
Date: Tue Feb 19 22:09:24 UTC 2019
New revision: 493396
URL: https://svnweb.freebsd.org/changeset/ports/493396

Log:
  Fix an incorrect sed regular expression used in libjava by adding a local
  patch files/patch-libjava-classpath-scripts-check_jni_methods.sh.in.
  Escapes of ordinary characters will be disallowed by regex(3) in the
  future. [1]

  While here already, factor out a proper USES block in the Makefile. [2]

  PR:		233443 [1]
  Submitted by:	kevans [1]
  Reported by:	portlint [2]

Changes:
  head/lang/gcc6/Makefile
  head/lang/gcc6/files/patch-libjava-classpath-scripts-check_jni_methods.sh.in