Bug 233590 - multimedia/obs-studio: fix fdk-aac v2
Summary: multimedia/obs-studio: fix fdk-aac v2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on: 233556
Blocks:
  Show dependency tree / graph
 
Reported: 2018-11-27 23:22 UTC by takefu
Modified: 2018-12-01 08:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
obs-studio-22.0.3_2.patch (1.33 KB, patch)
2018-11-27 23:22 UTC, takefu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2018-11-27 23:22:03 UTC 
Created attachment 199620 [details]
obs-studio-22.0.3_2.patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-27 23:36:31 UTC 
Hi takefu,

Could you please provide some background: what error message are you seeing, what led to this patch?

Thanks,
Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-28 03:01:28 UTC 
This patch needs to go into the upstream pull request.
The port should only have PATCHxx tokens added.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-28 08:23:38 UTC 
(In reply to Yuri Victorovich from comment #1)

Hi yuri, 

some members of AACENC_InfoStruct structure has been changed[1] between fdk-aac 0.1.6 and 2.0.0.
Consumers of fdk-aac should check the fdk-aac library version and take care of the difference of members.
Otherwise, updating audio/fdk-aac to 2.0.0 will break this port.

See also bug 233558.

[1] https://github.com/mstorsjo/fdk-aac/commit/6cfabd35363c3ef5e3b209b867169a500b3ccc3c#diff-b3d270e95452f0923c4f7ecf49dc44e0R1102
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-28 08:34:04 UTC 
(In reply to Koichiro Iwao from comment #3)

Yes, so this belongs in obs-studio's upstream, not in the port.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-01 08:31:19 UTC 
A commit references this bug:

Author: yuri
Date: Sat Dec  1 08:31:09 UTC 2018
New revision: 486325
URL: https://svnweb.freebsd.org/changeset/ports/486325

Log:
  multimedia/obs-studio: Compatibility fix for new obs-libfdk API

  PR:		233590

Changes:
  head/multimedia/obs-studio/Makefile
  head/multimedia/obs-studio/distinfo
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-12-01 08:31:58 UTC 
Committed PATCH_SITES/PATCHFILES pointing to the pull request.