Bug 233763 - security/clamav: broken when building without MSPACK
Summary: security/clamav: broken when building without MSPACK
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-04 01:57 UTC by Henry David Bartholomew
Modified: 2018-12-04 02:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ler)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henry David Bartholomew 2018-12-04 01:57:24 UTC
When building with the new MSPACK option disabled (which should force the use of the internal version of mspack) the installation of the resulting build fails as the following are not produced by the build or are not in the expected location.

[...]
pkg-static: Unable to access file /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/lib/libclammspack.a:No such file or directory
pkg-static: Unable to access file /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/libdata/pkgconfig/libclammspack.pc:No such file or directory

# ls -la /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/lib/libclammspack*  
lrwxr-xr-x 1 root wheel    22 2018-12-04 02:37 /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/lib/libclammspack.so -> libclammspack.so.0.1.0
lrwxr-xr-x 1 root wheel    22 2018-12-04 02:37 /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/lib/libclammspack.so.0 -> libclammspack.so.0.1.0
-rwxr-xr-x 1 root wheel 76100 2018-12-04 02:37 /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/lib/libclammspack.so.0.1.0
# ls -la /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/libdata/pkgconfig/*pc
-rw-r--r-- 1 root wheel 242 2018-12-04 02:37 /usr/ports/build//usr/ports/security/clamav/work/stage/usr/local/libdata/pkgconfig/libclamav.pc
#


It should be notedd the ports version of libmspack should NOT have been changed to the default as the internal version is newer/better/patched.

From the 0.101 release notes ( https://blog.clamav.net/2018/12/clamav-01010-has-been-released.html ):

"Upgrade from libmspack 0.5alpha to libmspack 0.7.1alpha. As a reminder, we support system-installed versions of libmspack. However, at this time the ClamAV-provided version of libmspack provides additional abilities to parse broken or non-standard CAB files beyond what the stock libmspack 0.7.1alpha provides. We are working with the upstream project to incorporate our modifications, and hopefully these changes will appear in a future release of libmspack."

The port version of libmspack is still using 0.5alpha.
Comment 1 Larry Rosenman freebsd_committer 2018-12-04 02:10:24 UTC
This was fixed in the tree.  There is a new version in ports as of this evening, that includes that fix (adding USES pkgconfig.

Short answer, get the latest ports tree (r486562 or later).
Comment 2 Henry David Bartholomew 2018-12-04 02:23:55 UTC
This is with that revision. Its still not fixed.
Comment 3 Larry Rosenman freebsd_committer 2018-12-04 02:40:22 UTC
Sorry about that. 

Fixed in r486579
Comment 4 commit-hook freebsd_committer 2018-12-04 02:40:31 UTC
A commit references this bug:

Author: ler
Date: Tue Dec  4 02:39:59 UTC 2018
New revision: 486579
URL: https://svnweb.freebsd.org/changeset/ports/486579

Log:
  security/clamav: build no longer produces libclammspack.a and
     libclammspack.pc with the MSPACK option unset.

  PR:		233763
  Reported by:	PopularMoment@protonmail.com

Changes:
  head/security/clamav/Makefile
  head/security/clamav/pkg-plist