Bug 233787 - [exp-run] move evdev related headers from v4l_compat to devel/evdev-proto and update consumers
Summary: [exp-run] move evdev related headers from v4l_compat to devel/evdev-proto and...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
Depends on:
Blocks: 222905
  Show dependency treegraph
Reported: 2018-12-04 22:17 UTC by Niclas Zeising
Modified: 2018-12-11 21:46 UTC (History)
2 users (show)

See Also:

add devel/evdev-proto and update consumers (20.01 KB, patch)
2018-12-04 22:17 UTC, Niclas Zeising
no flags Details | Diff
add devel/evdev-proto and update consumers+fixes (28.71 KB, patch)
2018-12-08 22:53 UTC, Vladimir Kondratyev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising freebsd_committer 2018-12-04 22:17:46 UTC
Created attachment 199831 [details]
add devel/evdev-proto and update consumers

Attached patch moves two evdev-releated headers, linux/input.h and linux/uinput.h from multimedia/v4l_compat to the new port devel/evdev-proto.
This makes it easier for the Graphics Team to keep track of those headers and to keep them updated independent of the other headers in v4l_compat.

Since this is a fairly large change, touching a number of ports, I'd like an exp-run to ensure I haven't missed updating any consumers.

This is a prerequisite for updating libinput and friends.
Comment 1 Vladimir Kondratyev freebsd_committer 2018-12-04 23:58:38 UTC
(In reply to Niclas Zeising from comment #0)
AFAIR, at least libevdev and py-evdev should be updated at the same commit to handle input-event-codes.h header split off.
Also, devel/libmtdev/files/patch-test-mtdev-test.c and x11-drivers/xf86-input-wacom/files/patch-src-wcmValidateDevice.c should be included too to fix __u16/__u64 type leaks
Comment 2 Niclas Zeising freebsd_committer 2018-12-06 22:26:46 UTC
(In reply to Vladimir Kondratyev from comment #1)

I'll look into this, thanks for the help!

My hope is to keep this change as small as possible, and then update consumers (libinput, libevdev and so on) after, but in case that's not possible, I'll update consumers as needed together with this.
Comment 3 Vladimir Kondratyev freebsd_committer 2018-12-08 22:53:25 UTC
Created attachment 199967 [details]
add devel/evdev-proto and update consumers+fixes

I attached basically the same patch with minor changes:

evdev-proto is based on 4.19 kernel rather than 4.16
libevdev and py-evdev versions are bumped. Current port versions do not know of new header (input-event-codes.h) existence.
Add patches for fixing of libmtdev and f86-input-wacom compilation.
Garbage collect libinput and evemu kludges which was introduced for support of old evdev headers.

I think it is minimal possible change.
Comment 4 Niclas Zeising freebsd_committer 2018-12-09 10:24:20 UTC
(In reply to Vladimir Kondratyev from comment #3)

Thank you.

I'll get this into our dev repo and if needed reroll the patch again.
Hopefully we can get the exp-run done soon. :)
Comment 6 Niclas Zeising freebsd_committer 2018-12-11 21:22:17 UTC
(In reply to Antoine Brodin from comment #5)

Thank you!
I'll work through these.
Do you think another exp run is warranted once these are fixed?
Comment 7 Antoine Brodin freebsd_committer 2018-12-11 21:46:42 UTC
(In reply to Niclas Zeising from comment #6)