Bug 234015 - [patch] [nfe] Add nForce MCP89 Networking Adapter support
Summary: [patch] [nfe] Add nForce MCP89 Networking Adapter support
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.0-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Johnston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-14 16:15 UTC by Andrejs Bogdanovs
Modified: 2018-12-21 02:27 UTC (History)
1 user (show)

See Also:


Attachments
add support for MCP89 Ethernet Controller (1.21 KB, patch)
2018-12-14 16:15 UTC, Andrejs Bogdanovs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrejs Bogdanovs 2018-12-14 16:15:43 UTC
Created attachment 200120 [details]
add support for MCP89 Ethernet Controller

Please, add support for nVidia nForce MCP89 Networking Adapter in nfe driver.

dmesg
---
nfe0: <NVIDIA nForce MCP89 Networking Adapter> port 0x22a0-0x22a7 mem 0xd3286000-0xd3287fff at device 9.0 on pci0
miibus0: <MII bus> on nfe0
---

pciconf -lv
---
nfe0@pci0:0:9:0:        class=0x020000 card=0xcb89106b chip=0x0d7d10de rev=0xa1 hdr=0x00
    vendor     = 'NVIDIA Corporation'
    device     = 'MCP89 Ethernet'
    class      = network
    subclass   = ethernet
---

I backported there changes from OpenBSD nfe driver.
(https://github.com/openbsd/src/commits/master/sys/dev/pci/if_nfe.c)

Tested changes in 12.0-RELEASE on Apple MacBook "Core 2 Duo" 2.4 13" (Mid-2010) with nForce MCP89 chipset:

pciconf -lv | grep MCP
---
    device     = 'MCP89 HOST Bridge'
    device     = 'MCP89 Memory Controller'
    device     = 'MCP89 LPC Bridge'
    device     = 'MCP89 Memory Controller'
    device     = 'MCP89 SMBus'
    device     = 'MCP89 Memory Controller'
    device     = 'MCP89 Co-Processor'
    device     = 'MCP89 OHCI USB 1.1 Controller'
    device     = 'MCP89 EHCI USB 2.0 Controller'
    device     = 'MCP89 OHCI USB 1.1 Controller'
    device     = 'MCP89 EHCI USB 2.0 Controller'
    device     = 'MCP89 High Definition Audio'
    device     = 'MCP89 Ethernet'
    device     = 'MCP89 SATA Controller (AHCI mode)'
    device     = 'MCP89 PCI Express Bridge'
    device     = 'MCP89 [GeForce 320M]'
---

Actually, just needed to add define for device id.
Comment 1 Andrejs Bogdanovs 2018-12-14 17:32:12 UTC
ifconfig output.

ifconfig nfe0
---
nfe0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=8210b<RXCSUM,TXCSUM,VLAN_MTU,TSO4,WOL_MAGIC,LINKSTATE>
        ether 70:cd:60:8c:e3:8e
        inet 192.168.1.51 netmask 0xffffff00 broadcast 192.168.1.255 
        media: Ethernet autoselect (1000baseT <full-duplex>)
        status: active
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
---
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-14 18:17:36 UTC
A commit references this bug:

Author: markj
Date: Fri Dec 14 18:16:35 UTC 2018
New revision: 342086
URL: https://svnweb.freebsd.org/changeset/base/342086

Log:
  Add support for the nForce MCP89 adapter.

  PR:		234015
  Submitted by:	Andrejs Bogdanovs <sinchiroca86@gmail.com>
  MFC after:	1 week

Changes:
  head/sys/dev/nfe/if_nfe.c
  head/sys/dev/nfe/if_nfereg.h
Comment 3 Andrejs Bogdanovs 2018-12-14 22:59:30 UTC
(In reply to commit-hook from comment #2)

Thank you, Mark!

Andrejs
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2018-12-15 05:10:22 UTC
(In reply to Andrejs Bogdanovs from comment #3)
Certainly, thanks for the patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-21 02:22:53 UTC
A commit references this bug:

Author: markj
Date: Fri Dec 21 02:22:11 UTC 2018
New revision: 342293
URL: https://svnweb.freebsd.org/changeset/base/342293

Log:
  MFC r342086:
  Add support for the nForce MCP89 adapter.

  PR:	234015

Changes:
_U  stable/12/
  stable/12/sys/dev/nfe/if_nfe.c
  stable/12/sys/dev/nfe/if_nfereg.h
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-12-21 02:26:58 UTC
A commit references this bug:

Author: markj
Date: Fri Dec 21 02:26:08 UTC 2018
New revision: 342294
URL: https://svnweb.freebsd.org/changeset/base/342294

Log:
  MFC r342086:
  Add support for the nForce MCP89 adapter.

  PR:	234015

Changes:
_U  stable/11/
  stable/11/sys/dev/nfe/if_nfe.c
  stable/11/sys/dev/nfe/if_nfereg.h