Bug 234210 - cad/gtkwave: fix build with GCC-based architectures
Summary: cad/gtkwave: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 13:47 UTC by Piotr Kubaj
Modified: 2018-12-23 20:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (zeising)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2018-12-20 13:47:22 UTC
This port needs USES=compiler:c++11-lang to build on GCC architectures.

While here, add USES=gnome.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Niclas Zeising freebsd_committer 2018-12-20 20:19:43 UTC
Which version have you looked at?  USES=gnome is already there.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-12-23 17:11:15 UTC
(In reply to Niclas Zeising from comment #1)

I'm wondering if the comment was cut-and-paste from one of the other similar ports PRs?

In any case I've tested on both amd64 and powerpc64 with the following patch:

-USES=          desktop-file-utils gettext gmake gnome gperf pkgconfig \
-               shared-mime-info
+USES=          compiler:c++11-lang desktop-file-utils gettext gmake \
+               gnome gperf pkgconfig shared-mime-info
Comment 3 commit-hook freebsd_committer 2018-12-23 20:41:21 UTC
A commit references this bug:

Author: zeising
Date: Sun Dec 23 20:40:55 UTC 2018
New revision: 488240
URL: https://svnweb.freebsd.org/changeset/ports/488240

Log:
  cad/gtkwave: Fix build on GCC-based architectures

  Fix build of cad/gtkwave on GCC-based architectures by adding
  compiler:c++11-lang to USES.

  PR:		234210
  Submitted by:	Piotr Kubaj

Changes:
  head/cad/gtkwave/Makefile
Comment 4 Niclas Zeising freebsd_committer 2018-12-23 20:41:53 UTC
Fixed, thanks!