Bug 234230 - multimedia/vlc3: Fix plugin cache broken (stale) due to strip(1)'ing
Summary: multimedia/vlc3: Fix plugin cache broken (stale) due to strip(1)'ing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: crash, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-12-20 20:42 UTC by Vladimir Kondratyev
Modified: 2018-12-29 13:05 UTC (History)
1 user (show)

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+


Attachments
Regenerate plugin cache broken by strip(1) (533 bytes, patch)
2018-12-20 20:42 UTC, Vladimir Kondratyev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kondratyev freebsd_committer freebsd_triage 2018-12-20 20:42:50 UTC
Created attachment 200319 [details]
Regenerate plugin cache broken by strip(1)

At the end of port staging Makefile issues strip(1) cmd on every plugin bundled.
That leads to stalled content of plugin cache (plugins.dat) and results in a lot of warnings [1] at the start of vlc and sometimes causes startup crashes [2] e.g. when gtk2 widgets are enabled with qt5ct.

Fix it with extra run of vlc-cache-gen right after the plugins have been stripped.

[1]. vlc warnings:

$ vlc
VLC media player 3.0.4 Vetinari (revision 3.0.4-0-gf615db6332)
[0000000800af0060] main libvlc error: stale plugins cache: modified /usr/local/lib/vlc/plugins/mux/libmux_ps_plugin.so
[0000000800af0060] main libvlc error: stale plugins cache: modified /usr/local/lib/vlc/plugins/mux/libmux_ogg_plugin.so
[0000000800af0060] main libvlc error: stale plugins cache: modified /usr/local/lib/vlc/plugins/mux/libmux_wav_plugin.so

[2]. vlc crash:

[0000000800acd060] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
qt5ct: using qt5ct plugin

(<unknown>:89888): Gtk-ERROR **: 23:30:11.352: GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported
zsh: trace trap (core dumped)  vlc
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-12-29 12:58:13 UTC
A commit references this bug:

Author: riggs
Date: Sat Dec 29 12:57:34 UTC 2018
New revision: 488663
URL: https://svnweb.freebsd.org/changeset/ports/488663

Log:
  Recreate stale plugin cache after stripping during staging

  PR:		234230
  Submitted by:	wulf
  MFH:		2018Q4

Changes:
  head/multimedia/vlc3/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-29 13:01:17 UTC
A commit references this bug:

Author: riggs
Date: Sat Dec 29 13:01:05 UTC 2018
New revision: 488664
URL: https://svnweb.freebsd.org/changeset/ports/488664

Log:
  MFH: r488663

  Recreate stale plugin cache after stripping during staging

  PR:		234230
  Submitted by:	wulf

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/multimedia/vlc3/Makefile