Bug 234651 - math/scilab not buildable without GUI option
Summary: math/scilab not buildable without GUI option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Don Lewis
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2019-01-06 02:19 UTC by Don Lewis
Modified: 2019-01-08 18:07 UTC (History)
0 users

See Also:
makc: maintainer-feedback+
koobs: merge-quarterly?


Attachments
patch to unbreak scilab build without GUI (1.38 KB, patch)
2019-01-06 02:19 UTC, Don Lewis
koobs: maintainer-approval+
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Lewis freebsd_committer 2019-01-06 02:19:55 UTC
Created attachment 200823 [details]
patch to unbreak scilab build without GUI

If the GUI option is not enabled, then the scilab build fails check-sanity:

=======================<phase: check-sanity   >============================
===>  scilab-5.5.2_15 need to specify gl component with USE_GL.
*** Error code 1

Fix by making USES=gl conditional on the GUI option.

While here, tweak Makefile statement ordering to reduce portlint warnings.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-01-06 09:41:54 UTC
Comment on attachment 200823 [details]
patch to unbreak scilab build without GUI

Approved by: portmgr (blanket: build/run/package fix)
Approved by: koobs (ports)

Pending QA

@Don Feel free to assign yourself to commit/merge (MFH) if this passes QA (poudriere)
Comment 2 Don Lewis freebsd_committer 2019-01-08 17:40:49 UTC
Successfully builds in puudriere on all supported releaaes as well as recent 13.0-CURRENT on i386 and amd64 both with and without the GUI option.
Comment 3 commit-hook freebsd_committer 2019-01-08 17:51:28 UTC
A commit references this bug:

Author: truckman
Date: Tue Jan  8 17:51:14 UTC 2019
New revision: 489729
URL: https://svnweb.freebsd.org/changeset/ports/489729

Log:
  Make USES=gl conditional on the GUI option to unbreak build when GUI is
  disabled.  Error was:
    scilab-5.5.2_15 need to specify gl component with USE_GL.
  because USE_GUI is conditional on GUI.

  While here, tweak Makefile statement ordering to reduce portlint warnings.

  PR:		234651
  Approved by:	makc (maintainer)
  MFH:		2019Q1

Changes:
  head/math/scilab/Makefile
Comment 4 commit-hook freebsd_committer 2019-01-08 18:06:41 UTC
A commit references this bug:

Author: truckman
Date: Tue Jan  8 18:05:51 UTC 2019
New revision: 489730
URL: https://svnweb.freebsd.org/changeset/ports/489730

Log:
  MFH: r489729

  Make USES=gl conditional on the GUI option to unbreak build when GUI is
  disabled.  Error was:
    scilab-5.5.2_15 need to specify gl component with USE_GL.
  because USE_GL is conditional on GUI.

  While here, tweak Makefile statement ordering to reduce portlint warnings.

  PR:		234651
  Approved by:	makc (maintainer)

  Approved by:	portmgr (blanket: build fix)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/math/scilab/Makefile