Bug 234709 - www/gitea: Add sqlite_unlock_notify tag
Summary: www/gitea: Add sqlite_unlock_notify tag
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
Depends on:
Reported: 2019-01-07 21:18 UTC by Adam Weinberger
Modified: 2019-01-07 21:33 UTC (History)
1 user (show)

See Also:
stb: maintainer-feedback+


Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2019-01-07 21:18:29 UTC
This is a request to enable the sqlite_unlock_notify tag when 1.7.0 is released.

When multiple concurrent git operations are made against a repo backed by gitea with a SQLite database, transient errors occur, such as:
  Gitea: Internal error 
  UpdatePublicKey: Failed to update public key: database is locked
  Gitea: You do not have allowed for this action
  User [user] does not have allowed access to repository [repo] 's code
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.

A new tag (sqlite_unlock_notify) was added recently to fix this, and it should arrive with 1.7.0. databases/sqlite builds with UNLOCK_NOTIFY enabled by default, so it should be safe to tie this new tag to the SQLITE option of gitea.

-SQLITE_VARS=    GO_TAGS+=sqlite
+SQLITE_VARS=    GO_TAGS+="sqlite sqlite_unlock_notify"
Comment 1 stb 2019-01-07 21:21:12 UTC
Do you have an upstream reference, like a GitHub issue? I'm happy to add this once 1.7 is released, but it would be great to have the upstream reference.
Comment 2 Adam Weinberger freebsd_committer 2019-01-07 21:33:28 UTC
Thank you for reminding me! I meant to attach these but completely forgot: