Bug 234739 - devel/llvm-devel: LLVM_BUILD_LLVM_DYLIB not passed to the build
Summary: devel/llvm-devel: LLVM_BUILD_LLVM_DYLIB not passed to the build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-08 11:27 UTC by Tobias Kortkamp
Modified: 2019-01-09 23:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2019-01-08 11:27:00 UTC
In devel/llvm-devel the first CMAKE_ARGS is overwritten like this

CMAKE_ARGS=     -DLLVM_BUILD_LLVM_DYLIB=ON                                      
CMAKE_ARGS=     -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON 

so -DLLVM_BUILD_LLVM_DYLIB=ON is never passed to the build.  Currently
llvm-devel does not appear to build a libLLVM.so.  Is this deliberate?

Can the first CMAKE_ARGS be removed or should it be passed through
to the build?
Comment 1 commit-hook freebsd_committer 2019-01-09 23:06:48 UTC
A commit references this bug:

Author: brooks
Date: Wed Jan  9 23:06:08 UTC 2019
New revision: 489840
URL: https://svnweb.freebsd.org/changeset/ports/489840

Log:
  Upgrade to a new snapshot.

  Fix a bug that resulted in LLVM_BUILD_LLVM_DYLIB not being passed as a
  cmake argument. [0]

  PR:		234739 [0]
  Submitted by:	tobik [0]

Changes:
  head/devel/llvm-devel/Makefile
  head/devel/llvm-devel/Makefile.snapshot
  head/devel/llvm-devel/distinfo
  head/devel/llvm-devel/files/openmp/patch-bug32279
  head/devel/llvm-devel/files/openmp/patch-i386
  head/devel/llvm-devel/pkg-plist
Comment 2 Brooks Davis freebsd_committer 2019-01-09 23:07:11 UTC
Thanks for the report!