Bug 234779 - textproc/pugixml: Update to 1.9 (fixes empty version field in pkg-config file)
Summary: textproc/pugixml: Update to 1.9 (fixes empty version field in pkg-config file)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/zeux/pugixml/relea...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-01-09 09:46 UTC by Tobias Kortkamp
Modified: 2019-01-18 18:24 UTC (History)
1 user (show)

See Also:
ybungalobill: maintainer-feedback+

Attachments
pugixml.diff (5.64 KB, patch)
2019-01-09 10:08 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (ybungalobill)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-09 09:46:19 UTC 
pugixml's pkg-config file has an empty value for its version field.
This is problematic since upstream packages might specify a minimum
version and will fail to accept our pugixml.

scripts/pugixml.pc.in has this

Version: @PUGIXML_VERSION_STRING@

so something must go wrong when substituting @PUGIXML_VERSION_STRING@
to create pugixml.pc.

Maybe an update to 1.9 would fix it?  It has been available since
April 2018.

https://github.com/zeux/pugixml/releases/tag/v1.9

----

prefix=/usr/local
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

Name: pugixml
Description: Light-weight, simple and fast XML parser for C++ with XPath support.
URL: http://pugixml.org/
Version: 
Cflags: -I${includedir}
Libs: -L${libdir} -lpugixml
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-09 10:08:05 UTC 
Created attachment 200950 [details]
pugixml.diff

Here is an update to 1.9 which doesn't have this problem.
I'd also like to request maintainership.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-09 10:22:33 UTC 
ABI: https://abi-laboratory.pro/tracker/timeline/pugixml/
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-18 18:23:23 UTC 
A commit references this bug:

Author: tobik
Date: Fri Jan 18 18:23:13 UTC 2019
New revision: 490646
URL: https://svnweb.freebsd.org/changeset/ports/490646

Log:
  textproc/pugixml: Update to 1.9

  This also fixes an empty version field in pugixml's pkg-config file.
  Some consumers like graphics/waylandpp refuse to use the system
  pugixml because of it.

  - Take maintainership
  - Cleanup some things that are no longer needed
  - Use CMAKE_{OFF,ON} helpers

  Changes:	https://pugixml.org/docs/manual.html#v1.9
  ABI:		https://abi-laboratory.pro/tracker/timeline/pugixml/
  PR:		234779
  Approved by:	ybungalobill@gmail.com (maintainer)

Changes:
  head/textproc/pugixml/Makefile
  head/textproc/pugixml/distinfo
  head/textproc/pugixml/files/patch-CMakeLists.txt
  head/textproc/pugixml/files/patch-scripts_pugixml.pc.in
  head/textproc/pugixml/files/patch-src_pugiconfig.hpp
  head/textproc/pugixml/pkg-plist
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-18 18:24:21 UTC 
Thank you very much.