Bug 234902 - net-p2p/deluge-cli: deluge_web disrespects user home directories.
Summary: net-p2p/deluge-cli: deluge_web disrespects user home directories.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-12 16:54 UTC by Phillip R. Jaenke
Modified: 2019-03-05 21:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rm)


Attachments
net-p2p_deluge-cli_files_deluge_web.in.patch (1.73 KB, text/plain)
2019-01-12 16:54 UTC, Phillip R. Jaenke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Phillip R. Jaenke 2019-01-12 16:54:34 UTC
Created attachment 201068 [details]
net-p2p_deluge-cli_files_deluge_web.in.patch

The rc.d script for deluge_web outright disrespects a user's home directory and instead tries to execute against hardcoded /home/${deluge_web_user} paths. This is invalid and dangerous behavior. When running as a user, the user's home directory must be respected.

The attached patch fixes this behavior as a break-fix. The script still needs rewritten to better conform to standards, but that is much lower priority.
Comment 1 commit-hook freebsd_committer 2019-03-05 21:14:35 UTC
A commit references this bug:

Author: rm
Date: Tue Mar  5 21:13:33 UTC 2019
New revision: 494743
URL: https://svnweb.freebsd.org/changeset/ports/494743

Log:
  net-p2p/deluge-cli: correct deluge_web rc-script

  From the PR:
  The rc.d script for deluge_web outright disrespects a user's home directory and
  instead tries to execute against hardcoded /home/${deluge_web_user} paths. This
  is invalid and dangerous behavior. When running as a user, the user's home
  directory must be respected. The attached patch fixes this behavior as a break-fix.

  PR:		234902
  Submitted by:	Phillip R. Jaenke <prj@rootwyrm.com>

Changes:
  head/net-p2p/deluge-cli/Makefile
  head/net-p2p/deluge-cli/files/deluge_web.in
Comment 2 Ruslan Makhmatkhanov freebsd_committer 2019-03-05 21:19:19 UTC
Committed, thank you!