Bug 234909 - [PATCH] audio/oss fix build on FreeBSD 11
Summary: [PATCH] audio/oss fix build on FreeBSD 11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-12 20:22 UTC by Craig Leres
Modified: 2019-01-12 23:05 UTC (History)
0 users

See Also:


Attachments
patch (801 bytes, patch)
2019-01-12 20:23 UTC, Craig Leres
leres: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2019-01-12 20:22:15 UTC
r489819 ("Unbreak port in FreeBSD 12 and 13-CURRENT") breaks the build for FreeBSD 11. This is because FreeBSD 11's sys/libkern.h has a prototype for memset() while later versions do not.

Here's an updated bsddefs.h patch that undefines memset when set and always defines memset to oss_memset.
Comment 1 Craig Leres freebsd_committer 2019-01-12 20:23:03 UTC
Created attachment 201080 [details]
patch
Comment 2 commit-hook freebsd_committer 2019-01-12 23:04:44 UTC
A commit references this bug:

Author: fernape
Date: Sat Jan 12 23:04:06 UTC 2019
New revision: 490082
URL: https://svnweb.freebsd.org/changeset/ports/490082

Log:
  audio/oss: Fix breakage after r489819

  The patch in r489819 broke the build in 11.

  Address that and make sure this one builds in {11.2,12}{amd64,i386} and
  13-CURRENT i386

  PR:	234909
  Reported by:	leres@

Changes:
  head/audio/oss/files/patch-kernel_OS_FreeBSD_wrapper_bsddefs.h
  head/audio/oss/files/patch-setup_srcconf__freebsd.inc
Comment 3 Fernando Apesteguía freebsd_committer 2019-01-12 23:05:38 UTC
Committed similar patch.

Thanks!