Bug 234981 - graphics/py-wand: Add DOCS option Pass MAINTAINER'ship
Summary: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://reviews.freebsd.org/D32031
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2019-01-15 20:30 UTC by rsmith
Modified: 2021-11-05 22:20 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (python)


Attachments
Patch for the port. (1.64 KB, patch)
2019-01-15 20:30 UTC, rsmith
no flags Details | Diff
build logs and tests for python 2.7 and 3.7. (2.27 KB, application/octet-stream)
2019-01-15 20:31 UTC, rsmith
no flags Details
Updated patch for 0.6.7 (1.96 KB, patch)
2021-09-18 16:48 UTC, rsmith
no flags Details | Diff
Updated patch to match ports tree as of 2021-10-17. (1.82 KB, patch)
2021-10-17 20:31 UTC, rsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2019-01-15 20:30:09 UTC
Created attachment 201169 [details]
Patch for the port.

Update graphics/py-wand to the latest release, 0.5.0.
Switch the ImageMagick dependency to version 7.
Comment 1 rsmith 2019-01-15 20:31:25 UTC
Created attachment 201170 [details]
build logs and tests for python 2.7 and 3.7.
Comment 2 Walter Schwarzenfeld freebsd_triage 2019-08-25 13:03:28 UTC
Maintainer feedback, please!
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-09-15 22:03:38 UTC
Hi,

Sorry for the long processing time, can you please bump this to the latest version available and are you also interested in becoming a maintainer of this port?

Best regards,
Daniel
Comment 4 rsmith 2021-09-18 16:48:04 UTC
Created attachment 227986 [details]
Updated patch for 0.6.7

This updated patch brings the port to 0.6.7, currently the latest version.
Comment 5 rsmith 2021-09-18 16:57:48 UTC
(In reply to Daniel Engberg from comment #3)

See attachment 227986 [details] for the updated patch.

I've omitted the build logs, but I ran all the tests mentioned in section 3.4 of the porters handbook, using Python 3.9.7. They all ran fine. Also, portlint reports no problems.

Note that I have added an option to install the documentation.
(The method was copied from devel/py-boolean.py)

You can sign me up as maintainer.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2021-10-12 20:54:47 UTC
Hi,

I apologize for the delay, sunpoet@ updated the port but I'd still like to add your contribution and set you as maintainer.

There's a WIP patch here (for the current version):
https://reviews.freebsd.org/D32031

If you can have a look at why Poudreire isn't happy it would be great.

Best regards,
Daniel
Comment 7 rsmith 2021-10-17 20:30:10 UTC
(In reply to Daniel Engberg from comment #6)

Well, I've looked at the review, but is wasn't very enlightening to me?

First off, how would I know from the review that Poudiere is unhappy? (FYI, I'm not using it.)

Second, the ",1" in the DOCS_BUILD_DEPENDS is used in *almost all* the ports. I'll admit that I just copied it.
If you want to check, just run

    ag 'sphinx>=' /usr/ports/devel/ | less

However, I've tried removing it and it doesn't seem to make a difference?

The documentation for py-wand states:

    Ensure to run Wand with the latest ImageMagick-7 library to
    take advantage of all the new methods.

So I think it's best to not enable ImageMagick-6 for this port.

I'll update the patch.
Comment 8 rsmith 2021-10-17 20:31:09 UTC
Created attachment 228787 [details]
Updated patch to match ports tree as of 2021-10-17.
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2021-10-18 09:50:16 UTC
Hi,

Thanks for the update!

===> Creating unique files: Move MAN files needing SUFFIX
===> Creating unique files: Move files needing SUFFIX

Is what I'm a bit concerned about.

According to https://docs.wand-py.org/en/0.6.7/guide/install.html#explicitly-link-to-specific-imagemagick and https://docs.wand-py.org/en/0.6.7/changes.html 6.X is still supported so I don't think we should drop it prematurely "just because".

Best regards,
Daniel
Comment 10 rsmith 2021-10-18 20:59:41 UTC
(In reply to Daniel Engberg from comment #9)

Regarding these messages:

===> Creating unique files: Move MAN files needing SUFFIX
===> Creating unique files: Move files needing SUFFIX

What is there to be concerned about? Aren't these normal progress messages?

Looking at the build;
- The messages are caused by the use of the "concurrent"
  feature; see python.mk. This enforces "USES=uniquefiles:dirs"
- The messages are generated during "make stage".
- They occur with the docs option on or off; so they are not
  uniquely related to the documentation, even though the
  documentation *is* put in a unique directory.
- There are *no* UNIX man pages in the packing list.
- The package contains no scripts or binaries.
- There are only two uniqe directories created:
    * work-py39/stage/usr/local/share/doc/py39-Wand
    * work-py39/stage/usr/local/share/licenses/py39-Wand-0.6.7
- There are *no* suffixed files in the stage tree.

With this in mind, I would say that these messages appear superfluous but harmless.

Using IMAGEMAGICK_DEFAULT is fine with me, since 7 is the default.

What I don't understand is the X11 option. Why do we care which flavor (if that is the correct term) of imagemagick is used? AFAICT, nothing in py-Wand uses X11.
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2021-11-02 16:18:41 UTC
Sorry for the late reply,

I read the messages as errors which is incorrect.
As for the X11 option it's to select the "correct" version of ImageMagick as dependency not related to the port itself.

Can we go with the variant I proposed (I'll rebase it) so we can maintain compatibility with both 6.x and 7.x for now?
Comment 12 rsmith 2021-11-03 16:41:01 UTC
(In reply to Daniel Engberg from comment #11)

Ok.
Comment 13 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-05 22:20:12 UTC
^Triage: Match summary with review that references this issue. Patch needs updating (in review, rebase against head, and here)