Created attachment 201169 [details] Patch for the port. Update graphics/py-wand to the latest release, 0.5.0. Switch the ImageMagick dependency to version 7.
Created attachment 201170 [details] build logs and tests for python 2.7 and 3.7.
Maintainer feedback, please!
Hi, Sorry for the long processing time, can you please bump this to the latest version available and are you also interested in becoming a maintainer of this port? Best regards, Daniel
Created attachment 227986 [details] Updated patch for 0.6.7 This updated patch brings the port to 0.6.7, currently the latest version.
(In reply to Daniel Engberg from comment #3) See attachment 227986 [details] for the updated patch. I've omitted the build logs, but I ran all the tests mentioned in section 3.4 of the porters handbook, using Python 3.9.7. They all ran fine. Also, portlint reports no problems. Note that I have added an option to install the documentation. (The method was copied from devel/py-boolean.py) You can sign me up as maintainer.
Hi, I apologize for the delay, sunpoet@ updated the port but I'd still like to add your contribution and set you as maintainer. There's a WIP patch here (for the current version): https://reviews.freebsd.org/D32031 If you can have a look at why Poudreire isn't happy it would be great. Best regards, Daniel
(In reply to Daniel Engberg from comment #6) Well, I've looked at the review, but is wasn't very enlightening to me? First off, how would I know from the review that Poudiere is unhappy? (FYI, I'm not using it.) Second, the ",1" in the DOCS_BUILD_DEPENDS is used in *almost all* the ports. I'll admit that I just copied it. If you want to check, just run ag 'sphinx>=' /usr/ports/devel/ | less However, I've tried removing it and it doesn't seem to make a difference? The documentation for py-wand states: Ensure to run Wand with the latest ImageMagick-7 library to take advantage of all the new methods. So I think it's best to not enable ImageMagick-6 for this port. I'll update the patch.
Created attachment 228787 [details] Updated patch to match ports tree as of 2021-10-17.
Hi, Thanks for the update! ===> Creating unique files: Move MAN files needing SUFFIX ===> Creating unique files: Move files needing SUFFIX Is what I'm a bit concerned about. According to https://docs.wand-py.org/en/0.6.7/guide/install.html#explicitly-link-to-specific-imagemagick and https://docs.wand-py.org/en/0.6.7/changes.html 6.X is still supported so I don't think we should drop it prematurely "just because". Best regards, Daniel
(In reply to Daniel Engberg from comment #9) Regarding these messages: ===> Creating unique files: Move MAN files needing SUFFIX ===> Creating unique files: Move files needing SUFFIX What is there to be concerned about? Aren't these normal progress messages? Looking at the build; - The messages are caused by the use of the "concurrent" feature; see python.mk. This enforces "USES=uniquefiles:dirs" - The messages are generated during "make stage". - They occur with the docs option on or off; so they are not uniquely related to the documentation, even though the documentation *is* put in a unique directory. - There are *no* UNIX man pages in the packing list. - The package contains no scripts or binaries. - There are only two uniqe directories created: * work-py39/stage/usr/local/share/doc/py39-Wand * work-py39/stage/usr/local/share/licenses/py39-Wand-0.6.7 - There are *no* suffixed files in the stage tree. With this in mind, I would say that these messages appear superfluous but harmless. Using IMAGEMAGICK_DEFAULT is fine with me, since 7 is the default. What I don't understand is the X11 option. Why do we care which flavor (if that is the correct term) of imagemagick is used? AFAICT, nothing in py-Wand uses X11.
Sorry for the late reply, I read the messages as errors which is incorrect. As for the X11 option it's to select the "correct" version of ImageMagick as dependency not related to the port itself. Can we go with the variant I proposed (I'll rebase it) so we can maintain compatibility with both 6.x and 7.x for now?
(In reply to Daniel Engberg from comment #11) Ok.
^Triage: Match summary with review that references this issue. Patch needs updating (in review, rebase against head, and here)