Bug 235103 - audio/lv2: fix build with Python > 3.6
Summary: audio/lv2: fix build with Python > 3.6
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Carlo Strub
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2019-01-21 10:08 UTC by Charlie Li
Modified: 2019-02-06 20:44 UTC (History)
2 users (show)

See Also:
beerml: maintainer-feedback+


Attachments
lv2-python.patch (868 bytes, patch)
2019-01-21 10:08 UTC, Charlie Li
no flags Details | Diff
Update to version 1.16.0 including fix for python bug + add missing dependencies (3.46 KB, patch)
2019-02-06 20:44 UTC, Michael Beer
beerml: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Li 2019-01-21 10:08:08 UTC
Created attachment 201303 [details]
lv2-python.patch

While lv2 itself works fine with any Python version we support, the build fails using a Python greater than 3.6, since the build pulls in and uses an old version of waf. waf upstream fixed the bug in a later version:

https://gitlab.com/ita1024/waf/commit/facdc0b173d933073832c768ec1917c553cb369c

Restrict Python to 3.6 and under for now.

This passes poudriere-testport.
Comment 1 Carlo Strub freebsd_committer 2019-01-31 21:43:00 UTC
There are several missing dependencies. I get the following warnings:

Warning: you need USE_GNOME+=gdkpixbuf2
Error: /usr/local/lib/lv2/eg-sampler.lv2/sampler_ui.so is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig
Error: /usr/local/lib/lv2/eg-sampler.lv2/sampler_ui.so is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2

Please have a look.
Comment 2 Michael Beer 2019-02-06 20:44:46 UTC
Created attachment 201801 [details]
Update to version 1.16.0 including fix for python bug + add missing dependencies

This update to the latest lv2 version should fix the python issue with python 3.7 according to the release notes.
Furthermore I added additional dependencies (fontconfig, freetype, pango) for the example plugins.