Bug 235482 - net/libmaxminddb: use GCC on i386 since using clang generates an incorrect maxminddb_config.h
Summary: net/libmaxminddb: use GCC on i386 since using clang generates an incorrect ma...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 235154
  Show dependency treegraph
 
Reported: 2019-02-04 08:52 UTC by Ralf van der Enden
Modified: 2019-02-05 14:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Change to GCC on i386 (734 bytes, patch)
2019-02-04 08:52 UTC, Ralf van der Enden
no flags Details | Diff
Add sunpoet's patch to fix maxminddb_config.h on i386 (1.93 KB, patch)
2019-02-05 13:52 UTC, Ralf van der Enden
tremere: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2019-02-04 08:52:36 UTC
Created attachment 201710 [details]
Change to GCC on i386

On i386 building with Clang gives you an incorrect include/maxminddb_config.h.
configure tries to detect support for unsigned __int128 in two ways. The first one fails for both GCC and Clang, but the second is incorrectly detected as true by Clang. This can cause issues in packages depending on libmaxminddb (.ie security/modsecurity3)

Bump portrevision because a new maxminddb_config.h needs to be generated on i386. Also petted portlint so it doesn't generate any errors anymore.
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-02-05 12:55:43 UTC
Try https://people.FreeBSD.org/~sunpoet/patch/net-libmaxminddb.txt instead of using GCC on i386.
Comment 2 Ralf van der Enden 2019-02-05 13:52:12 UTC
Created attachment 201763 [details]
Add sunpoet's patch to fix maxminddb_config.h on i386


Your patch works as expected, so redid my initial patch.
Comment 3 commit-hook freebsd_committer 2019-02-05 14:27:32 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Feb  5 14:26:58 UTC 2019
New revision: 492238
URL: https://svnweb.freebsd.org/changeset/ports/492238

Log:
  Fix __int128 detection on i386

  PR:		235482
  Reported by:	Ralf van der Enden <tremere@cainites.net>

Changes:
  head/net/libmaxminddb/Makefile
  head/net/libmaxminddb/files/
  head/net/libmaxminddb/files/patch-configure
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2019-02-05 14:28:12 UTC
Committed. Thanks!