Bug 235995 - devel/google-perftools: arm64 not supported
Summary: devel/google-perftools: arm64 not supported
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-24 13:11 UTC by John F. Carr
Modified: 2019-02-25 10:12 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+


Attachments
Possible fix (357 bytes, patch)
2019-02-24 20:19 UTC, John F. Carr
no flags Details | Diff
patch (1.52 KB, patch)
2019-02-25 10:12 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John F. Carr 2019-02-24 13:11:45 UTC
Comnpiling google-perftools on arm64 fails with an error:

src/stacktrace.cc:230:2: error: Cannot calculate stack trace: will need to write for your environment

There might be an easy fix aside from disabling the port for arm64.  The package includes several stack trace implementations, one of which might be useful.
Comment 1 Yuri Victorovich freebsd_committer 2019-02-24 17:33:25 UTC
(In reply to John F. Carr from comment #0)

Unfortunately, I don't have arm here.

Are you able to provide the patch?
Comment 2 John F. Carr 2019-02-24 20:19:57 UTC
Created attachment 202339 [details]
Possible fix

This is an untested fix.  I verified it causes libunwind to be added as a dependency.  I don't want to build binutils, which is a prerequisite for libunwind, so I can't test.  I will look for a better fix that doesn't lead to dependency hell.
Comment 3 Mikael Urankar freebsd_committer 2019-02-25 10:12:23 UTC
Created attachment 202347 [details]
patch

it builds with this patch, but the tests aren't so good:
============================================================================
Testsuite summary for gperftools 2.7
============================================================================
# TOTAL: 45
# PASS:  21
# SKIP:  0
# XFAIL: 0
# FAIL:  24
# XPASS: 0
# ERROR: 0