Bug 236038 - [NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML
Summary: [NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/ktbyers/nxapi-plum...
Keywords: feature
Depends on:
Blocks:
 
Reported: 2019-02-25 19:50 UTC by John W. O'Brien
Modified: 2019-03-03 16:24 UTC (History)
2 users (show)

See Also:

Attachments
[NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML (3.21 KB, text/plain)
2019-02-25 19:50 UTC, John W. O'Brien 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2019-02-25 19:50:29 UTC 
Created attachment 202364 [details]
[NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML

Description
===========

A low-level library for Python to manage Cisco Nexus devices
network electronics through NX-API using JSON-RPC and XML.

QA
==

portlint: OK
poudriere: OK -- testport on 11.2-RELEASE amd64 w/py27, py35, py36 (default), and py37
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-02-26 02:53:40 UTC 
Thanks John,

Review items: 

- Minor: Match a projects upstream description (setup.py:description) as closely as possible, with COMMENT (portlint) compliance changes where necessary. In this case "Library for managing Cisco devices through NX-API using XML or jsonrpc"

- Projects setup.py:url is a 404, can you send an upstream issue/PR to correct it

- sdist includes tests and a test command (in tox.ini not shipped in sdist). Add TEST_DEPENDS (pytest) and a do(test) target for QA. The following should work:

do-test:
    @cd ${WRKSRC}} && ${PYTHON_CMD} -m pytest -v -s test

Would be great to confirm those tests pass as well
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-02-26 03:03:43 UTC 
based on upstream requirements-dev.txt, further (compulsory) TEST_DEPENDS probably include:

mock
pytest
PyYAML

Maybe

pylama

It would be nice to have compulsory test requirements in setup.py:tests_require
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2019-02-28 10:43:49 UTC 
Came on this PR by coincidence. I had already started a review for that port on 21st February to upgrade net-mgmt/py-napalm afterwards: https://reviews.freebsd.org/D19288
Comment 4 John W. O'Brien 2019-02-28 10:52:38 UTC 
(In reply to Kai Knoblich from comment #3)

OK to close this as OBE.
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2019-03-03 16:24:57 UTC 
Closing this as "Overcome by events" because the port appeared the first time as a review on Phabricator as outlined in comment #3. net-mgmt/py-nxapi-plumbing was committed then in ports r494513.