Bug 236059 - lang/go: r493967 build fails in poudriere (need USES=shebangfix for 'go/src/internal/x/fiximports.bash')
Summary: lang/go: r493967 build fails in poudriere (need USES=shebangfix for 'go/src/i...
Status: Closed DUPLICATE of bug 236159
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
: 236064 (view as bug list)
Depends on:
Blocks: 236094 236131
  Show dependency tree / graph
 
Reported: 2019-02-26 16:32 UTC by Dmitri Goutnik
Modified: 2019-03-02 18:33 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)

Attachments
SHEBANG_FILES patch (422 bytes, patch)
2019-02-26 16:32 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
remove pkg/bootstrap (40.42 KB, patch)
2019-02-26 16:33 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
[patch] add missing shebangfix file, v2 (594 bytes, patch)
2019-03-01 17:21 UTC, John Hein 		jcfyecrayz: maintainer-approval? (jlaffaye)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2019-02-26 16:32:32 UTC 
Created attachment 202385 [details]
SHEBANG_FILES patch

- Add src/internal/x/fiximports.bash to SHEBANG_FILES

QA:
  poudriere testport: OK (112a, 120a)
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2019-02-26 16:33:24 UTC 
Created attachment 202386 [details]
remove pkg/bootstrap

I also thought it would be a good opportunity to update port to not install pkg/bootstrap which is go14-compiled bootstrapping toolchain and is not needed after build.
Comment 2 Walter Schwarzenfeld 2019-02-26 19:18:55 UTC 
*** Bug 236064 has been marked as a duplicate of this bug. ***
Comment 3 John Hein 2019-03-01 17:21:17 UTC 
Created attachment 202485 [details]
[patch] add missing shebangfix file, v2

This version of the patch addresses the missing fiximports.bash and also removes perl from SHEBANG_LANG since that is already added in Mk/Uses/shebangfix.mk (causing perl to be in the list twice).
Comment 4 John Hein 2019-03-01 17:24:29 UTC 
(In reply to John Hein from comment #3)
Has anyone suggested to upstream that they not specify bash in the shebang for all these scripts that don't need bash features?  Good for them that they are not coding with non-posix bashisms, but why not use #!/bin/sh?
Comment 5 John Hein 2019-03-01 23:43:58 UTC 
(In reply to John Hein from comment #4)
It looks like a few of the bash scripts really do have bashisms.  For example:

 IFS=$'\n'

 . make.bash "$@" --no-banner

 '&>'

So this port should probably not be using /bin/sh in shebangs - at least not in those scripts using the bashisms.  Of course, those bashisms could pretty easily be converted to posix - then using /bin/sh would be fine.

p.s. Sorry for hijacking the bug.  The bash vs sh issue is really a separate bug.
Comment 6 Walter Schwarzenfeld 2019-03-02 18:30:41 UTC 
*** Bug 236159 has been marked as a duplicate of this bug. ***
Comment 7 Julien Laffaye freebsd_committer freebsd_triage 2019-03-02 18:33:19 UTC 

*** This bug has been marked as a duplicate of bug 236159 ***