Bug 236215 - net/freeswitch: fails to build with clang 8
Summary: net/freeswitch: fails to build with clang 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch
Depends on:
Blocks: 236062
  Show dependency tree / graph
 
Reported: 2019-03-04 13:21 UTC by Jan Beich
Modified: 2019-05-11 11:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (corsmith)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-03-04 13:21:46 UTC 
$ poudriere jail -cj clang8 -v projects/clang800-import -m svn+https
$ poudriere testport -j clang8 net/freeswitch
[...]
sip_pref_util.c:328:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("audio") || MATCH("automata") || MATCH("application") ||
           ^~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:328:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:328:30: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("audio") || MATCH("automata") || MATCH("application") ||
                             ^~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:328:30: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:328:51: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("audio") || MATCH("automata") || MATCH("application") ||
                                                  ^~~~~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:328:51: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:329:7: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
      MATCH("actor");
      ^~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:329:7: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:332:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("class") || MATCH("control");
           ^~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:332:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:332:30: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("class") || MATCH("control");
                             ^~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:332:30: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:335:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("duplex") || MATCH("data") || MATCH("description");
           ^~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:335:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:335:31: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("duplex") || MATCH("data") || MATCH("description");
                              ^~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:335:31: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:335:48: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("duplex") || MATCH("data") || MATCH("description");
                                               ^~~~~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:335:48: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:338:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("events");
           ^~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:338:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:341:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("isfocus");
           ^~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:341:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:344:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("language");
           ^~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:344:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:347:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("mobility") || MATCH("methods");
           ^~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:347:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:347:33: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("mobility") || MATCH("methods");
                                ^~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:347:33: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:350:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("priority");
           ^~~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:350:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:353:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("schemes");
           ^~~~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:353:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:356:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("type");
           ^~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:356:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
sip_pref_util.c:359:12: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
    base = MATCH("video");
           ^~~~~~~~~~~~~~
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                            ~~^~~
sip_pref_util.c:359:12: note: use array indexing to silence this warning
sip_pref_util.c:315:31: note: expanded from macro 'MATCH'
  (su_casenmatch(param + 1, s + 1, strlen(s) - 1) && \
                              ^
18 errors generated.

http://package18.nyi.freebsd.org/data/headamd64PR236062-default/2019-03-01_06h42m53s/logs/errors/freeswitch-1.8.1_2.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-03-04 23:31:12 UTC 
Reminder: Clang 8 was merged to 13.0-CURRENT in base r344779. Maintainers, expect pkg-fallout@ mail soon.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-05-11 11:08:52 UTC 
Workaround applied in ports r501243.