Bug 236326 - math/reduce: fails to build with clang 8 on i386
Summary: math/reduce: fails to build with clang 8 on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: i386 Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords: needs-patch
Depends on:
Blocks: 236062
  Show dependency treegraph
 
Reported: 2019-03-06 16:55 UTC by Jan Beich
Modified: 2019-03-13 15:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (pfg)


Attachments
upstream fix (add this file to the files dir) (8.39 KB, patch)
2019-03-13 02:51 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-03-06 16:55:36 UTC
checking for size_t... configure: error: max_align_t must be at least 8 for CSL to work
[...]
install  -m 0644 /usr/ports/math/reduce/work/Reduce-svn4868-src/cslbuild/i386-unknown-freebsd13.0/csl/reduce.img /usr/ports/math/reduce/work/stage/usr/local/share/reduce
install: /usr/ports/math/reduce/work/Reduce-svn4868-src/cslbuild/i386-unknown-freebsd13.0/csl/reduce.img: No such file or directory
*** Error code 71

http://package18.nyi.freebsd.org/data/headi386PR236062-default/2019-03-04_22h33m48s/logs/errors/reduce-20190120.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-03-06 16:55:59 UTC
Probably caused by https://reviews.llvm.org/rL345419
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-03-07 04:14:02 UTC
In all honesty, I have no idea what to do about it.
I am checking upstream.
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-03-08 00:21:52 UTC
(In reply to Pedro F. Giffuni from comment #2)

Consulting upstream: the authors have been losing interest un i386 as a platform and will need to do adjustments in the code for this.

While I guess we could use clang 7, perhaps it's better to just tag the port broken for i386 (there is still reduce-psl).
Comment 4 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-03-10 23:28:36 UTC
(In reply to Pedro F. Giffuni from comment #3)

Great news: upstream is actively working on this and will have a fix soon.
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2019-03-13 02:51:25 UTC
Created attachment 202834 [details]
upstream fix (add this file to the files dir)

Upstream committed a fix.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-03-13 15:42:14 UTC
A commit references this bug:

Author: jbeich
Date: Wed Mar 13 15:41:26 UTC 2019
New revision: 495584
URL: https://svnweb.freebsd.org/changeset/ports/495584

Log:
  math/reduce: unbreak with clang 8 on i386

  PR:		236326
  Submitted by:	pfg (maintainer)
  Obtained from:	upstream

Changes:
  head/math/reduce/files/patch-svn-r4935
Comment 7 Jan Beich freebsd_committer freebsd_triage 2019-03-13 15:43:15 UTC
Thanks. Builds fine after applying the patch.