Created attachment 202736 [details] Patch to update x11/xfce4-screenshooter-plugin Update to 1.9.4
Thanks I'm also testing a similar patch.
Port update itself works fine, but when trying to use it it's failing to save screenshots to disk. Using the "save" option causes an error message: Failed to open "<home dir>" for writing: Is a directory Looking at git history the file saving code was heavily refactored and updated. Something must have been broken on the way. Looks like the code fails to append a filename when actually saving the screenshot to disk. I'm trying to investigate this and maybe I'll file a bug report upstream.
Filed a bug report upstream. The problem happens only when using the panel plugin.
(In reply to Guido Falsi from comment #2) I encountered this bug, since several previous releases (only on FreeBSD, not under Linux) when I save picture, with default filename. I don't know it's same behaviour.
(In reply to Olivier Duchateau from comment #4) > (In reply to Guido Falsi from comment #2) > > I encountered this bug, since several previous releases (only on FreeBSD, > not under Linux) when I save picture, with default filename. I don't know > it's same behaviour. I have just tested in VMs. Previous (1.9.3) version in FreeBSD does not show the broken behaviour. It did show the file requester when sending a screenshot to a file via the panel plugin. I also tested in a Linux Manjaro VM I have, they just updated heir packages to include version 1.9.4 and I can see the same broken behaviour there, so it IS present in linux too. Can be easily reproduced by adding the screenshoot plugin to the panel, left clicking on it and accepting the default (saving to file). It definitely looks like a regression.
(In reply to Guido Falsi from comment #5) I think I find the problem (not yet tested, it will wait tomorrow). In action_idle function (lib/screenshooter-actions.c): > if (!sd->path_is_dir) > screenshooter_save_screenshot_to (sd->screenshot, sd->screenshot_dir); > else 2nd member of 'screenshooter_save_screenshot_to' must be a filename (see lib/screenshooter-dialogs.c) and not a directory.
(In reply to Olivier Duchateau from comment #6) In config file (~/.config/xfce4/xfce4-screenshooter) value of screenshot_dir is path to folder.
Version 1.9.5 with a fix for the issue I reported is out. I'm going to commit an update to this version shortly.
A commit references this bug: Author: madpilot Date: Sun Mar 31 18:47:23 UTC 2019 New revision: 497439 URL: https://svnweb.freebsd.org/changeset/ports/497439 Log: Update xfce4-screenshooter-plugin to 1.9.5 PR: 236417 Submitted by: Olivier Duchateau <duchateau.olivier@gmail.com> Changes: head/x11/xfce4-screenshooter-plugin/Makefile head/x11/xfce4-screenshooter-plugin/distinfo
Update committed. Thanks!