Bug 236418 - x11-toolkits/py-xlib: Update to 0.25
Summary: x11-toolkits/py-xlib: Update to 0.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://reviews.freebsd.org/D19617
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2019-03-09 11:12 UTC by Olivier Duchateau
Modified: 2019-03-25 16:20 UTC (History)
2 users (show)

See Also:
fax: maintainer-feedback+

Attachments
Patch to update x11-toolkits/py-xlib (1.70 KB, patch)
2019-03-09 11:12 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-03-09 11:12:25 UTC 
Created attachment 202737 [details]
Patch to update x11-toolkits/py-xlib

- Update to 0.25
- Adjust WWW entry (pkg-descr)
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2019-03-10 16:00:26 UTC 
(In reply to Olivier Duchateau from comment #0)

Hi Olivier,

thank you for the patch. I have just one question out of curiousness: Is there a particular reason to switch from USE_GITHUB to MASTER_SITES (that still points to Github)?
Comment 2 Olivier Duchateau 2019-03-11 17:28:05 UTC 
(In reply to Kai Knoblich from comment #1)

Because with MASTER_SITES macro, tarball is well formed.
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2019-03-17 21:53:40 UTC 
(In reply to Olivier Duchateau from comment #2)

Alright, that seems to be reasonable, although it seems a bit inconvenient for a project that is hosted on GitHub.

But there's another solution which incorporates most of your changes: I switched from Github back to CHEESESHOP (which is also the preferred origin for Python ports). Even the DISTNAME keeps the same: python-xlib-0.25.tar.bz2.

At the moment the patch in on pre-commit review. Once it gets approved it's ready to land.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-03-25 16:19:27 UTC 
A commit references this bug:

Author: kai
Date: Mon Mar 25 16:19:09 UTC 2019
New revision: 496837
URL: https://svnweb.freebsd.org/changeset/ports/496837

Log:
  x11-toolkits/py-xlib: Update to 0.25

  While I'm here:

  * Fix license
  * Set MASTER_SITES to CHEESESHOP
  * Pet portlint

  Changelog since 0.23-4:

  * Fix increasing memory usage on display instantiation
  * Fix protocol handling: correctly support explicit Unix connections and fix
    support fox macOS
  * Fix xfixes example
  * Fix a bunch of typos in the code / documentation
  * Improve Python 3 support: fix events sub-code handling and possible crashes
    when unpacking text data
  * Add support for error handlers to the Composite extension

  NV-CONTROL extension

  * Add first implementation by Roberto Leinardi

  https://github.com/python-xlib/python-xlib/blob/0.25/CHANGELOG.md

  PR:		236418
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  Approved by:	miwi (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19617

Changes:
  head/x11-toolkits/py-xlib/Makefile
  head/x11-toolkits/py-xlib/distinfo
  head/x11-toolkits/py-xlib/pkg-descr
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2019-03-25 16:20:54 UTC 
Committed, thank you for the patch!