Bug 236440 - security/arpCounterattack - Build failure (net/libpcap)
Summary: security/arpCounterattack - Build failure (net/libpcap)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-10 05:43 UTC by the.silicon.projects+freebsd-bugzilla
Modified: 2019-05-24 16:07 UTC (History)
2 users (show)

See Also:


Attachments
svn-diff-arpCounterattac (1.33 KB, patch)
2019-03-11 14:47 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-arpCounterattac_v2 (1.33 KB, patch)
2019-03-13 08:15 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description the.silicon.projects+freebsd-bugzilla 2019-03-10 05:43:57 UTC
When port PCAP library (net/libpcap) is installed, it seems to prefer the port version over the base system version, but it fails to link to.

To avoid useless dependency, please force use base system PCAP library even when port version is installed, or setup a radio button to let the user choose which library to prefer.

Unfortunately, I can't get rid of net/libpcap as net/daq a dependency of security/snort, requires it expressively
Comment 1 Walter Schwarzenfeld 2019-03-11 14:47:33 UTC
Created attachment 202792 [details]
svn-diff-arpCounterattac
Comment 2 Walter Schwarzenfeld 2019-03-11 14:49:58 UTC
If got this error, is this the same as for you:

arpCounterattack.cpp:491:56: error: use of undeclared identifier 'BIOCIMMEDIATE'
      if (ioctl(pcap_fileno(interfaces[i].descriptor), BIOCIMMEDIATE,
                                                       ^
Comment 3 the.silicon.projects+freebsd-bugzilla 2019-03-11 15:20:24 UTC
(In reply to w.schwarzenfeld from comment #2)

Yes, this is the same error

Best Regards,

Davis
Comment 4 Walter Schwarzenfeld 2019-03-11 15:46:40 UTC
Does the patch work?
Comment 5 the.silicon.projects+freebsd-bugzilla 2019-03-13 03:47:57 UTC
(In reply to w.schwarzenfeld from comment #4)

I have tested the patch

Here is the report :

===>   arpCounterattack-1.2.0_6 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by arpCounterattack-1.2.0_6 for building
===>  Extracting for arpCounterattack-1.2.0_6
=> SHA256 Checksum OK for arpCounterattack-1.2.0.tbz.
===>  Patching for arpCounterattack-1.2.0_6
===>  Applying FreeBSD patches for arpCounterattack-1.2.0_6
1 out of 2 hunks failed--saving rejects to arpCounterattack.cpp.rej
=> FreeBSD patch patch-arpCounterattack.cpp failed to apply cleanly.
=> Patch(es)  patch-address.hpp applied cleanly.
*** Error code 1

Best regards,

David
Comment 6 Walter Schwarzenfeld 2019-03-13 07:24:32 UTC
Something went wrong for you:

My output:
===>   arpCounterattack-1.2.0_7 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by arpCounterattack-1.2.0_7 for building
===>  Extracting for arpCounterattack-1.2.0_7
=> SHA256 Checksum OK for arpCounterattack-1.2.0.tbz.
===>  Patching for arpCounterattack-1.2.0_7


Your output tells 1.2.0_6.
Maybe patch < svn-diffsecurity/arpCounterattack went wrong.
Comment 7 Walter Schwarzenfeld 2019-03-13 08:03:32 UTC
Oh, I see it, it is any svn nonsense. But I did not find it yet.
Comment 8 Walter Schwarzenfeld 2019-03-13 08:15:24 UTC
Created attachment 202835 [details]
svn-diff-arpCounterattac_v2

This should work.
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-05-24 16:07:10 UTC
A commit references this bug:

Author: swills
Date: Fri May 24 16:06:32 UTC 2019
New revision: 502484
URL: https://svnweb.freebsd.org/changeset/ports/502484

Log:
  security/arpCounterattack: fix build failure

  PR:		236440
  Submitted by:	w.schwarzenfeld@utanet.at
  Reported by:	my-roaming-data@outlook.com

Changes:
  head/security/arpCounterattack/Makefile
  head/security/arpCounterattack/files/patch-address.hpp
  head/security/arpCounterattack/files/patch-arpCounterattack.cpp
Comment 10 Steve Wills freebsd_committer freebsd_triage 2019-05-24 16:07:43 UTC
Committed, thanks!