Bug 236618 - devel/py-odfpy: Add missing dependencies
Summary: devel/py-odfpy: Add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-18 15:39 UTC by Kai Knoblich
Modified: 2019-03-20 14:33 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
py-odfpy-add-depenendies.patch (689 bytes, patch)
2019-03-18 15:39 UTC, Kai Knoblich
kai: maintainer-approval? (wen)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2019-03-18 15:39:11 UTC
Created attachment 202959 [details]
py-odfpy-add-depenendies.patch

Hi Wen,

during the preparations and testing of the 0.13.0 update of textproc/py-tablib following error occurred when importing the "tablib" module:

> >>> import tablib
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/local/lib/python2.7/site-packages/tablib/__init__.py", line 3, in <module>
>     from tablib.core import (
>   File "/usr/local/lib/python2.7/site-packages/tablib/core.py", line 16, in <module>
>     from tablib import formats
>   File "/usr/local/lib/python2.7/site-packages/tablib/formats/__init__.py", line 13, in <module>
>     from . import _ods as ods
>   File "/usr/local/lib/python2.7/site-packages/tablib/formats/_ods.py", line 6, in <module>
>     from odf import opendocument, style, table, text
>   File "/usr/local/lib/python2.7/site-packages/odf/opendocument.py", line 44, in <module>
>     from odf.odfmanifest import manifestlist
>   File "/usr/local/lib/python2.7/site-packages/odf/odfmanifest.py", line 24, in <module>
>     from defusedxml.sax import make_parser
> ImportError: No module named defusedxml.sax

This is caused by devel/py-odfpy that is still missing devel/py-defusedxml as dependency. Interestingly this error doesn't occur if you import devel/py-odfpy alone.

The attached patch adds devel/py-defusedxml to RUN_DEPENDS, bumps the PORTREVISION and sorts the variables a bit according to the PHB.

QA:
~~~
- poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r344874 amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-18 23:31:50 UTC
A commit references this bug:

Author: wen
Date: Mon Mar 18 23:31:38 UTC 2019
New revision: 496223
URL: https://svnweb.freebsd.org/changeset/ports/496223

Log:
  - Add missing RUN_DEPENDS

  PR:		236618
  Submitted by:	kai@

Changes:
  head/devel/py-odfpy/Makefile