Bug 236774 - security/keepassxc: Fails to build with KEESHARE option disabled
Summary: security/keepassxc: Fails to build with KEESHARE option disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL: https://github.com/keepassxreboot/kee...
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2019-03-25 09:15 UTC by Guido Falsi
Modified: 2019-03-25 09:37 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (melanhit)
madpilot: merge-quarterly-


Attachments
patch (2.00 KB, patch)
2019-03-25 09:18 UTC, Guido Falsi
madpilot: maintainer-approval? (melanhit)
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2019-03-25 09:15:34 UTC
As stated in the subject I noticed keepassxc fails with the KEESHARE option disabled with the following error:

/wrkdirs/usr/ports/security/keepassxc/work/keepassxc-2.4.0/src/gui/DatabaseWidget.cpp:1115:5: error: use of undeclared identifier 'm_shareLabel'
    m_shareLabel->setVisible(false);
    ^
1 error generated.



I have found a commit upstream addressing this:

https://github.com/keepassxreboot/keepassxc/commit/eb9ff677d0c681a86a9ef296f5a363549b94c42c



Attaching a patch including this patch in the port.
Comment 1 Guido Falsi freebsd_committer 2019-03-25 09:18:24 UTC
Created attachment 203119 [details]
patch

patch was lost for some reason in submission.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-03-25 09:21:31 UTC
Comment on attachment 203119 [details]
patch

Approved by: portmgr (blanket: bugfix, build/run fix)
Comment 3 Guido Falsi freebsd_committer 2019-03-25 09:34:44 UTC
Version in 2019Q1 is not affected, does not have the KEESHARE option.
Comment 4 commit-hook freebsd_committer 2019-03-25 09:36:48 UTC
A commit references this bug:

Author: madpilot
Date: Mon Mar 25 09:36:32 UTC 2019
New revision: 496805
URL: https://svnweb.freebsd.org/changeset/ports/496805

Log:
  Import upstream paatch which fixes build when KEESHARE is disabled.

  PR:		236774
  Submitted by:	myself
  Approved by:	portmgr (blanket: bugfix, build/run fix)
  Obtained from:	https://github.com/keepassxreboot/keepassxc/commit/eb9ff677d0c681a86a9ef296f5a363549b94c42c

Changes:
  head/security/keepassxc/files/patch-src_gui_DatabaseWidget.cpp
Comment 5 Guido Falsi freebsd_committer 2019-03-25 09:37:25 UTC
Committed with blanket approval.