Bug 237203 - sysutils/py-google-compute-engine: Fix bug under 3.x, Add missing dependency
Summary: sysutils/py-google-compute-engine: Fix bug under 3.x, Add missing dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-04-11 12:31 UTC by Miroslav Lachman
Modified: 2019-05-13 11:16 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lucas.kanashiro)
koobs: merge-quarterly?


Attachments
fix upstream bug, add py-distro as dependency (1.98 KB, patch)
2019-04-11 12:31 UTC, Miroslav Lachman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2019-04-11 12:31:01 UTC
Created attachment 203588 [details]
fix upstream bug, add py-distro as dependency

sysutils/py-google-compute-engine built as py36-google-compute-engine-2.8.6 does not work because:
1) it requires py-distro which is not recorded  as dependency fo py36 flavour
2) has upstream bug in compat.py in FreeBSD detection

See this pull request:
https://github.com/GoogleCloudPlatform/compute-image-packages/pull/756

It can be fixed in a few different ways.
It can even be modified to not need py-distro at all. (but I don't know how to modify content of python3.6/site-packages/google_compute_engine-2.8.6-py3.6.egg-info/requires.txt - I am no Python developer.

Attached patch fixes it for me. Built in poudriere, used with Python 3.6, py-distro as dependency for py36 flavours.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-14 06:51:16 UTC
Conditional check for python version should use PYTHON_VER
Comment 2 Miroslav Lachman 2019-04-15 10:00:25 UTC
(In reply to Kubilay Kocak from comment #1)
I am not sure I understand what you mean. I used .if ${FLAVOR:Upy36:Mpy3*} as I found it in handbook and in the other port
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/flavors-using.html
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-23 20:18:44 UTC
A commit references this bug:

Author: swills
Date: Tue Apr 23 20:17:45 UTC 2019
New revision: 499790
URL: https://svnweb.freebsd.org/changeset/ports/499790

Log:
  sysutils/py-google-compute-engine: update to 20190416 [1]

  This fixes a python3 runtime issue [1]

  While here, pull in missing dependency in python3 case [2]

  PR:		237505 [1]
  PR:		237203 [2]
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer) [1]
  Submitted by:	Miroslav Lachman <000.fbsd@quip.cz> [2]
  Approved by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer) [2]

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/distinfo
Comment 4 Steve Wills freebsd_committer freebsd_triage 2019-04-23 20:19:00 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-05-13 11:16:51 UTC
A commit references this bug:

Author: swills
Date: Mon May 13 11:16:31 UTC 2019
New revision: 501552
URL: https://svnweb.freebsd.org/changeset/ports/501552

Log:
  MFH: r498656 r499790 r501547

  Patch to add missing config and take the maintainership

  Two new variables was added to instance_config.cfg file
  in version 2.8.13 to allow the addition and removal of
  users from groups.
  I am also taking over the maintainership of this packages
  as previously discussed with Helen.

  Bump PORTREVISION.

  PR:		236500
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com>
  Approved by:	Helen Koike <helen.koike@collabora.com> (maintainer)

  sysutils/py-google-compute-engine: update to 20190416 [1]

  This fixes a python3 runtime issue [1]

  While here, pull in missing dependency in python3 case [2]

  PR:		237505 [1]
  PR:		237203 [2]
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer) [1]
  Submitted by:	Miroslav Lachman <000.fbsd@quip.cz> [2]
  Approved by:	Lucas Kanashiro <lucas.kanashiro@collabora.com> (maintainer) [2]

  sysutils/py-google-compute-engine: fix daemons in python 2.7 case

  PR:		237845
  Reviewed by:	koobs
  Approved by:	implicit (portmgr, python, jfi blanket)

  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2019Q2/
  branches/2019Q2/sysutils/py-google-compute-engine/Makefile
  branches/2019Q2/sysutils/py-google-compute-engine/distinfo
  branches/2019Q2/sysutils/py-google-compute-engine/files/google_accounts_daemon.in
  branches/2019Q2/sysutils/py-google-compute-engine/files/google_clock_skew_daemon.in
  branches/2019Q2/sysutils/py-google-compute-engine/files/google_instance_setup.in
  branches/2019Q2/sysutils/py-google-compute-engine/files/google_network_daemon.in
  branches/2019Q2/sysutils/py-google-compute-engine/files/google_startup.in
  branches/2019Q2/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample