Bug 237248 - mail/thunderbird: TOC time off by 2 hours when DST is in effect
Summary: mail/thunderbird: TOC time off by 2 hours when DST is in effect
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-12 22:59 UTC by Craig Leres
Modified: 2019-04-13 03:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
9:18 am message show as 7:18 (11.46 KB, image/png)
2019-04-12 22:59 UTC, Craig Leres
no flags Details
10:40pm message shown as 8:40pm (13.27 KB, image/png)
2019-04-12 23:00 UTC, Craig Leres
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2019-04-12 22:59:17 UTC
Created attachment 203628 [details]
9:18 am message show as 7:18

For some time now I've noticed that the displayed message time sometimes differs between the TOC and message itself. I am able to reproduce using a thunderbird package from pkg.freebsd.org but does not happen under windows 10.

My theory is that the code is subtracting instead of adding an hour. I tested this by setting the system time back before DST took effect and the problem went away.

I took a stab at finding the place where TOC date formatting occurs but thunderbird is just too big for someone who doesn't work on it.

I'll attach a couple of screen grabs that show the problem.
Comment 1 Craig Leres freebsd_committer 2019-04-12 23:00:15 UTC
Created attachment 203629 [details]
10:40pm message shown as 8:40pm
Comment 2 Jan Beich freebsd_committer 2019-04-13 00:31:24 UTC
(In reply to Craig Leres from comment #0)
> My theory is that the code is subtracting instead of adding an
> hour. I tested this by setting the system time back before DST took
> effect and the problem went away.

DST adjusts 1 hour but the screenshot show discrepancy in 2 hours. Does it also occur with "TZ=UTC thunderbird"?

> I took a stab at finding the place where TOC date formatting occurs
> but thunderbird is just too big for someone who doesn't work on it.

Code specific to Thunderbird is under comm/mail/, code shared with SeaMonkey is under comm/mailnews/, code shared with Firefox is outside of comm/.
Comment 3 Craig Leres freebsd_committer 2019-04-13 00:39:49 UTC
(In reply to Jan Beich from comment #2)
> Does it also occur with "TZ=UTC thunderbird"?

It works correctly with "env TZ=UTC thunderbird"
Comment 4 Craig Leres freebsd_committer 2019-04-13 03:51:22 UTC
In mozilla-speak the "message list pane" is what I called the TOC.

When I tested the pkg.freebsd.org version of thunderbird I tried to eliminate things that are custom in my environment. So I moved my ~/.thunderbird directory and configured it to talk to an imaps server from scratch. But all of the dependent ports were from my build server.

I have a ubuntu desktop I use for testing and I configured one imaps server on it and it works correctly.

Given that I can only reproduce this on FreeBSD I looked for files in freebsd directories and found some javascript that is doing date things. How is the message list pane rendered?

(Does anybody else see this bug?)