Bug 237296 - net/ndproxy: fix build with GCC-based architectures
Summary: net/ndproxy: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-15 09:34 UTC by Piotr Kubaj
Modified: 2019-04-30 13:53 UTC (History)
2 users (show)

See Also:
fbsd.bugzilla: maintainer-feedback+

Attachments
patch (556 bytes, patch)
2019-04-15 09:34 UTC, Piotr Kubaj 		fbsd.bugzilla: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-15 09:34:50 UTC 
Created attachment 203688 [details]
patch

Add -Wno-error=strict-prototypes to fix build with GCC:
cc1: warnings being treated as errors
ndproxy.c:92: warning: function declaration isn't a prototype [-Wstrict-prototypes]
ndproxy.c:116: warning: function declaration isn't a prototype [-Wstrict-prototypes]

Tested on powerpc64 and amd64.
Comment 1 Alexandre Fenyo 2019-04-15 09:45:50 UTC 
Comment on attachment 203688 [details]
patch

These are two static functions without arguments, these warnings have no impact.
Thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-30 13:53:42 UTC 
A commit references this bug:

Author: pkubaj
Date: Tue Apr 30 13:53:23 UTC 2019
New revision: 500492
URL: https://svnweb.freebsd.org/changeset/ports/500492

Log:
  net/ndproxy: add -Wno-error=strict-prototypes to CFLAGS when using GCC

  This is needed to fix build:
  ndproxy.c:51: function declaration isn't a prototype

  PR:		237296
  Approved by:	fbsd.bugzilla@fenyo.net (maintainer), mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20013

Changes:
  head/net/ndproxy/Makefile