Bug 237555 - textproc/topic: fix build with GCC-based architectures
Summary: textproc/topic: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-25 12:27 UTC by Piotr Kubaj
Modified: 2019-05-20 16:37 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (email)

Attachments
patch (611 bytes, patch)
2019-04-25 12:27 UTC, Piotr Kubaj 		pkubaj: maintainer-approval? (email)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-25 12:27:21 UTC 
Created attachment 204003 [details]
patch

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

Tested on powerpc64 and amd64.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-05-20 16:37:18 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon May 20 16:36:24 UTC 2019
New revision: 502123
URL: https://svnweb.freebsd.org/changeset/ports/502123

Log:
  textproc/topic: fix build with GCC-based architectures

  Specifically specify signed char to fix build error on powerpc64.

  PR:		237555
  Approved by:	email@freebsd.hypermart.net (maintainer timeout), mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20285

Changes:
  head/textproc/topic/Makefile
  head/textproc/topic/files/
  head/textproc/topic/files/patch-linenoise.c