Bug 237847 - graphics/opencv: Update to 4.1.0
Summary: graphics/opencv: Update to 4.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-05-12 07:55 UTC by Hiroo Ono
Modified: 2021-01-30 18:11 UTC (History)
9 users (show)

See Also:
koobs: maintainer-feedback? (hiroo.ono+freebsd)

Attachments
opencv 3.4.1 -> 4.1.0 patch (239.89 KB, patch)
2019-05-12 07:55 UTC, Hiroo Ono 		no flags Details | Diff
patch to graphics/caffe (4.97 KB, patch)
2019-05-12 07:57 UTC, Hiroo Ono 		no flags Details | Diff
opencv 3.4.1 -> 4.1.0 patch (214.32 KB, patch)
2019-05-22 15:36 UTC, Hiroo Ono 		no flags Details | Diff
patch to astro/siril to depend on opencv4 (4.08 KB, patch)
2019-05-22 15:37 UTC, Hiroo Ono 		no flags Details | Diff
patch to ports that depends on opencv4 (9.11 KB, patch)
2019-05-22 15:42 UTC, Hiroo Ono 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2019-05-12 07:55:43 UTC 
Created attachment 204333 [details]
opencv 3.4.1 -> 4.1.0 patch

This is a patch to update graphics/opencv (and related) ports to 4.1.0.
It is related to bug #237135 which copies graphics/opencv to graphics/opencv3 and updates to 3.4.6.
This patch creates one more slave port graphics/opencv-contrib to avoid circular dependency between graphics/caffe.

To be able to install opencv3 and opencv4 at the same time, I moved include files and libraries to subdirectory of ${LOCALBASE}/include and ${LOCALBASE}/lib. As a consequent, about 40 ports dependent on graphics/opencv need to be patched. The patch to graphics/caffe follows and multimedia/ffmpeg is dealt in the bug #237135, but the patches for other ports are not ready.

Problem: I did not add CONFLICTS, but graphics/py-opencv and graphics/py-opencv3 install the library files to the same location, and cannot coexists. Is there any way for both versions to coexist?
Comment 1 Hiroo Ono 2019-05-12 07:57:04 UTC 
Created attachment 204334 [details]
patch to graphics/caffe

Patch to graphics/caffe depended by graphics/opencv-contrib if option CAFFE is enabled.
Comment 2 Hiroo Ono 2019-05-22 15:36:05 UTC 
Created attachment 204542 [details]
opencv 3.4.1 -> 4.1.0 patch

Some correction to the patch:

- With IPP option, a little more patching was needed.
- Restored NONFREE option.
Comment 3 Hiroo Ono 2019-05-22 15:37:11 UTC 
Created attachment 204543 [details]
patch to astro/siril to depend on opencv4
Comment 4 Hiroo Ono 2019-05-22 15:42:03 UTC 
Created attachment 204544 [details]
patch to ports that depends on opencv4

Among the ports in categories astro or graphics, that depend on graphics/opencv(-core), these ports could be built with opencv4:

astro/siril (separate patch)
graphics/caffe (separate patch)
graphics/digikam
graphics/nomacs
graphics/openimageio
graphics/waifu2x-converter-cpp
graphics/yafaray
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2019-08-12 11:12:37 UTC 
Can't help with this port, back to the pool
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2019-09-25 20:59:58 UTC 
4.1.1 released already.
Comment 7 Ari Suutari 2020-01-16 07:43:22 UTC 
Anyone planning any activity on this ? I tried to apply 
opencv 3.4.1 -> 4.1.0 patch from here, but it seems that other
changes have made it a little bit difficult to apply.

4.1 version might be helpful for python use cases that use also tensorflow.
Comment 8 Li-Wen Hsu freebsd_committer freebsd_triage 2020-07-02 04:16:57 UTC 
Hiroo: do you want to maintain the graphics/opencv port?
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-03 02:29:54 UTC 
^Triage: 

- [tags] in issue Titles are deprecated
- If any referenced issues are blocked by or depend on this issue, please add them to this issues Blocked By or Depends On fields accordingly
- Track feedback request from Hiroo (comment 9)
Comment 10 Hiroo Ono 2020-11-23 10:20:09 UTC 
(In reply to Li-Wen Hsu from comment #8)
Currently, no. I do not have enough time to rework the patch. I want to try to update the patch later, but I have to address the problem stated in #237933 then.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2020-12-19 15:39:48 UTC 
4.5.0 is out
Comment 12 Tobias C. Berner freebsd_committer freebsd_triage 2021-01-30 18:11:42 UTC 
Overcome by https://svnweb.freebsd.org/ports?view=revision&revision=563430