Bug 237854 - math/octave: adds JAVA and QT5 option, improves library stripping
Summary: math/octave: adds JAVA and QT5 option, improves library stripping
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-12 20:49 UTC by Lorenzo Salvadore
Modified: 2019-05-15 03:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (stephen)

Attachments
octave - optionnal java, qt5 (6.75 KB, patch)
2019-05-12 20:49 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval? (stephen)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2019-05-12 20:49:00 UTC 
Created attachment 204339 [details]
octave - optionnal java, qt5

This patch adds JAVA and QT5 option, improves library stripping:

- java supports becomes optional (enabled by default);
- removes "java" from CATEGORIES because java is now optional;
- qt5 support (i.e. gui support) becomes optional (enabled by default);
- improves library stripping: without this patch only liboctave was stripped, now all libraries are by defining INSTALL_TARGET= install-strip;
- bumps PORTREVISION (packages change due to the stripping improvement and to the "java" removal from CATEGORIES).

Tested successfully on 12.0-STABLE r347145 amd64 and with poudriere on 12.0-RELEASE amd64.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-05-15 03:13:52 UTC 
A commit references this bug:

Author: stephen
Date: Wed May 15 03:12:56 UTC 2019
New revision: 501680
URL: https://svnweb.freebsd.org/changeset/ports/501680

Log:
  - add JAVA and QT5 option, improve library stripping.
  - Bump portrevision.

  PR:		237854
  Submitted by:	phascolarctos@protonmail.ch

Changes:
  head/math/octave/Makefile
  head/math/octave/pkg-plist
Comment 2 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2019-05-15 03:14:34 UTC 
Committed.  Thank you.