Created attachment 204456 [details]
[patch] fix developer sanity check when USES=ssl
After bsd.sanity.mk added a check for "incorrectly set options helpers" (approx Apr 18), some ports started failing check-sanity if DEVELOPER=yes.
You can see this with at least devel/gsoap and net/libvncserver.
% make DEVELOPER=yes check-sanity
/!\ gsoap-2.8.83: Makefile errors /!\
The following options helpers are incorrectly set after bsd.port.options.mk
and are ineffective: OPENSSL_LDFLAGS
*** Error code 1
make: stopped in /usr/ports/devel/gsoap
I think the fix is to change Uses/ssl.mk to specify LDFLAGS instead of OPENSSL_LDFLAGS. Attached.
CC tobik@ who made the sanity check change.
This no longer happens since OPENSSL_LDFLAGS is already whitelisted
since ports r499267.
(In reply to Tobias Kortkamp from comment #2)
> This no longer happens since OPENSSL_LDFLAGS is already whitelisted
> since ports r499267.
Sorry I meant ports r501786.
(In reply to Tobias Kortkamp from comment #3)
Ok, thanks for that information.
It seems better to just use LDFLAGS in Uses/ssl.mk than to whitelist OPENSSL_LDFLAGS (which could mask a real mistake).
Fixed at ports r501786