Created attachment 204489 [details]
Thank you for contributing a new port Greg
- Python packages that install scripts (this one does) should be made concurrent safe. Use USE_PYTHON=concurrent for this, which handles most files automatically.
- Port does not specify USES=python:<version-spec>, which (implicitly) declares support for any Python version, but it is unclear what versions this package supports. In particular, if this package only supports Python 2 or 3 *only*, <version-spec> must be declared accordingly
Upstream (https://github.com/jaksi/leviathan/blob/0.1.1/README.md) suggest using pip3 leviathan which implies it supports Python 3, but it is unclear if it *requires* Python 3. Please confirm
- Confirm this port passes QA (portlint, poudriere in particular) for all Python (major) versions it supports.
Created attachment 204546 [details]
Yes, it does work with Python 2. portlint passes. py27 and py36 flavors build under Synth. (why wouldn't they, it's not like a compiled language where a missing library would cause a build-time error)
Since this software has now (post 0.1.1) been converted into a Linux kernel module/driver, and the Python code has essentially been 'replaced', it might be worth either:
a) Asking upstream to create a separate repository for the Python code to live in, that can receive updates/fixes. There's at least packaging fixes and support for more devices to be added (that are now supported in the latest versions).
b) In the even upstream declines, fork the repository so that the module can evolve on its own
A commit references this bug:
Date: Mon May 27 04:10:17 UTC 2019
New revision: 502764
[NEW PORT] sysutils/py-leviathan: Application to control and monitor NZXT (Asetek) liquid coolers
CLI application to control and monitor NZXT (and possibly other USB connected)
NZXT is NOT involved in this project, do NOT contact them if your device
is damaged while using this software.
Submitted by: Greg V <greg unrelenting technology>
Committed with minor changes:
- Add LICENSE_FILE, commented with reason/explanation
- Remove pyusb min version requirement (not declared in setup.py)
Thanks for the new port submission Greg!