Bug 238021 - graphics/milton: fix build with GCC-based architectures, please portlint
Summary: graphics/milton: fix build with GCC-based architectures, please portlint
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 12:53 UTC by Piotr Kubaj
Modified: 2019-06-15 12:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
patch (2.42 KB, patch)
2019-05-21 12:53 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (danfe)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-05-21 12:53:10 UTC
Created attachment 204508 [details]
patch

Move USE_GITHUB and INSTALLS_ICONS to please portlint.

Add -DNO_WARN_X86_INTRINSICS -maltivec -mvsx to CXXFLAGS on powerpc64 to use the new Intel SIMD software translation mode in GCC.

Add ifdefs for a couple of E* macros to files/patch-src_shadergen.cc.

Errors:
/wrkdirs/usr/ports/graphics/milton/work/milton-1.6.0/src/shadergen.cc:364:13: error: 'ENODATA' was not declared in this scope
        case ENODATA:         str = "No message is available on the STREAM head read queue (POSIX.1)"; break;
             ^~~~~~~
/wrkdirs/usr/ports/graphics/milton/work/milton-1.6.0/src/shadergen.cc:364:13: note: suggested alternative: 'ENOTTY'
        case ENODATA:         str = "No message is available on the STREAM head read queue (POSIX.1)"; break;
             ^~~~~~~
             ENOTTY
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-05-29 21:27:52 UTC
This builds for me, so once the maintainer approves, consider this mentor approval.
Comment 2 Alexey Dokuchaev freebsd_committer 2019-06-04 15:53:59 UTC
Thanks for the patch.  Let me see if I can reproduce the errors on my Mac mini G4 here (I'm particularly curious about those EFOOBAR #ifdef's).

> Move USE_GITHUB and INSTALLS_ICONS to please portlint.
Actually, portlint(1) warning is bogus here: GitHub-related (that is, fetch-related) knobs are deliberately grouped together.
Comment 3 Piotr Kubaj freebsd_committer 2019-06-04 15:59:52 UTC
(In reply to Alexey Dokuchaev from comment #2)
Just note that you won't be able to run the binary that is compiled with this patch.

VSX was introduced in POWER8. However there's currently no way to set IGNORE depending on the POWER CPU generation.