Bug 238038 - x11/py-pyvirtualdisplay: add pyscreenshot dependency
Summary: x11/py-pyvirtualdisplay: add pyscreenshot dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-22 01:11 UTC by Steve Wills
Modified: 2019-05-27 15:45 UTC (History)
1 user (show)

See Also:

Attachments
patch to add pyscreenshot dep and backend options (1.73 KB, patch)
2019-05-22 01:11 UTC, Steve Wills 		daniel: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2019-05-22 01:11:59 UTC 
Created attachment 204528 [details]
patch to add pyscreenshot dep and backend options

While here, add options for backends and reformat a bit.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-22 03:29:59 UTC 
Added in ports r502238

@Steve, I don't see pillow referenced in pyscreenshot's setup.py [1], and pyvirtualdisplay already depends on it. Is the pillow dependency spurious in pyscreenshot?

[1] setup.py:install_requires = ['EasyProcess']
Comment 2 Steve Wills freebsd_committer freebsd_triage 2019-05-22 20:34:30 UTC 
(In reply to Kubilay Kocak from comment #1)
No, pyscreenshot does need it, it's just not mentioned in the setup.py. And even if it were it would be an issue for pyscreenshot, not pyvirtualdisplay.
Comment 3 Daniel Ylitalo 2019-05-27 07:42:56 UTC 
Comment on attachment 204528 [details]
patch to add pyscreenshot dep and backend options

Sorry for the late reply, looks good to me and thanks for the improvment! :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-05-27 15:44:41 UTC 
A commit references this bug:

Author: swills
Date: Mon May 27 15:44:09 UTC 2019
New revision: 502801
URL: https://svnweb.freebsd.org/changeset/ports/502801

Log:
  x11/py-pyvirtualdisplay: Update to 0.2.3 [1]

  While here, add pyscreenshot dependency and add backend options [2]

  PR:		238155 [1]
  PR:		238038 [2]
  Approved by:	Daniel Ylitalo <daniel@blodan.se> (maintainer) [1] [2]

Changes:
  head/x11/py-pyvirtualdisplay/Makefile
  head/x11/py-pyvirtualdisplay/distinfo
Comment 5 Steve Wills freebsd_committer freebsd_triage 2019-05-27 15:45:40 UTC 
Committed, thanks!