Bug 238232 - [patch] sysrc ignores the -i ignore flag
Summary: [patch] sysrc ignores the -i ignore flag
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 12.0-STABLE
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-05-30 01:06 UTC by Yann Kerherve
Modified: 2019-06-05 14:39 UTC (History)
3 users (show)

See Also:


Attachments
simple patch to sysrc for -i (486 bytes, text/plain)
2019-05-30 01:06 UTC, Yann Kerherve
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Kerherve 2019-05-30 01:06:54 UTC
Created attachment 204709 [details]
simple patch to sysrc for -i

There is no functional difference between -q and -i.

The -i flag is documented as:

   Ignore unknown variables.

The -q flag is documented as:

   Quiet.  Disable verbose and hide certain errors.  When combined
   with ‘-L’ and one or more name arguments, provide only exit
   status and no output.


The current behavior is observed:

$ sysrc unknown
sysrc: unknown variable 'unknown'
$ echo $?
1
$ sysrc -q unknown
$ echo $?
1
$ sysrc -i unknown
$ echo $?
1


When the following behavior is expected:
$ sysrc -i unknown
sysrc: unknown variable 'unknown'
$ echo $?
0

Combining with the -q flag
$ sysrc -q -i unknown
$ echo $?
0

The following patch:
- Makes -i exit code 0
- Makes -i not suppress output unless combined with -q
Comment 1 Ed Maste freebsd_committer 2019-06-05 14:39:13 UTC
dteske@ can you review?