Bug 238306 - net/openbgpd: rc.d script check_process() no longer finds parent bgpd process
Summary: net/openbgpd: rc.d script check_process() no longer finds parent bgpd process
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Hiroki Sato
URL:
Keywords: needs-patch, regression
Depends on:
Blocks:
 
Reported: 2019-06-03 10:50 UTC by Stewart Morgan
Modified: 2019-06-03 13:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
Patch check_process() to find the parent bgpd process without a process-title change (235 bytes, patch)
2019-06-03 13:42 UTC, Stewart Morgan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stewart Morgan 2019-06-03 10:50:13 UTC
In the previous version (5.2), the parent process changed its process title to "bgpd: parent".  In 6.5, it doesn't, so the rc.d script's check_process() function fails to find it.

Since (at least by default) the parent process runs as root, a simple fix would be to change check_process() to use: /bin/pgrep -U 0 -f 'bgpd'.

I've tested this on 11.2 and 12.0 (amd64).
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-06-03 10:57:39 UTC
Thank you for the report Stewart.

If you could attach a patch implementing the check_process() in the ports files/openbgpd.in file that would be appreciated
Comment 2 Stewart Morgan 2019-06-03 13:42:32 UTC
Created attachment 204805 [details]
Patch check_process() to find the parent bgpd process without a process-title change

Requested patch.