Bug 238500 - net/ocserv: upgrading stable/12 past r345045 makes ocserv unable to reap its children, turning the VPN service into a one-shot service
Summary: net/ocserv: upgrading stable/12 past r345045 makes ocserv unable to reap its ...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL: https://gitlab.com/openconnect/ocserv...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-11 14:44 UTC by Trond.Endrestol
Modified: 2019-06-13 22:46 UTC (History)
0 users

See Also:
cpm: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Trond.Endrestol 2019-06-11 14:44:04 UTC
I'm stuck figuring out what causes net/ocserv to only serve the first connect on stable/12 past r345045.

When a client does the very first disconnect, a couple of ocserv child processes end up as zombies. The main process is unable to serve new clients and naturally it doesn't reap its dead children. Killing the main ocserv process is futile, not even killall -kill ocserv helps.

I tried stable/12 r348883 today, and it's the same story.

Any pointers are appreciated.
Comment 1 Carlos J. Puga Medina freebsd_committer 2019-06-11 16:29:19 UTC
(In reply to Trond.Endrestol from comment #0)

Hi,

I have not used ocserv for a long time.

Have you reported the problem upstream?

https://gitlab.com/openconnect/ocserv/issues
Comment 2 Trond.Endrestol 2019-06-12 06:18:24 UTC
(In reply to Carlos J. Puga Medina from comment #1)
I did just now: https://gitlab.com/openconnect/ocserv/issues/213
Comment 3 Trond.Endrestol 2019-06-12 06:21:40 UTC
BZ just stated:

https://gitlab.com/openconnect/ocserv/issues/213 is not a valid URL to a bug.

See Also URLs should point to one of:

show_bug.cgi in a Bugzilla installation.
A bug on launchpad.net
An issue on code.google.com.
A bug on bugs.debian.org.
An issue in a JIRA installation.
A ticket in a Trac installation.
A bug in a MantisBT installation.
A bug on sourceforge.net.
An issue/pull request on github.com.
A review on reviews.freebsd.org.
A PR on NetBSD GNATS system.
An issue on Google Chromium issue tracker.
An issue on bitbucket.org.

I guess gitlab.com should be added to the list.
Comment 4 Carlos J. Puga Medina freebsd_committer 2019-06-13 22:46:56 UTC
(In reply to Trond.Endrestol from comment #3)

Good catch! Your request can be taken into account if you file a new PR.

Thanks