Bug 238696 - sysutils/reed : include dirent.h instead of deprecated sys/dir.h
Summary: sysutils/reed : include dirent.h instead of deprecated sys/dir.h
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks: 21519
  Show dependency treegraph
 
Reported: 2019-06-18 19:36 UTC by Rene Ladan
Modified: 2019-06-19 08:36 UTC (History)
2 users (show)

See Also:
crees: maintainer-feedback+


Attachments
include dirent.h instead of sys/dir.h (599 bytes, patch)
2019-06-18 19:36 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer 2019-06-18 19:36:51 UTC
Created attachment 205210 [details]
include dirent.h instead of sys/dir.h

reed includes sys/dir.h, but that header is scheduled for removal and dirent.h should be included instead. Update this port for that.
Comment 1 Chris Rees freebsd_committer 2019-06-18 21:50:15 UTC
Sounds great, thanks.  Please go ahead.
Comment 2 Chris Rees freebsd_committer 2019-06-19 08:14:28 UTC
Actually, I have a couple more changes to make.
Comment 3 commit-hook freebsd_committer 2019-06-19 08:30:09 UTC
A commit references this bug:

Author: crees
Date: Wed Jun 19 08:29:56 UTC 2019
New revision: 504525
URL: https://svnweb.freebsd.org/changeset/ports/504525

Log:
  sysutils/reed: Remove sys/dir.h

  It was replaced a long time ago with sys/dirent.h, which is implicitly
  included from dirent.h

  Use sed instead of perl, remove redundant seds and use a patch for the
  source file for clarity

  PR:		ports/238696
  Submitted by:	rene

Changes:
  head/sysutils/reed/Makefile
  head/sysutils/reed/files/patch-cfg.data
  head/sysutils/reed/files/patch-reed.c
Comment 4 Chris Rees freebsd_committer 2019-06-19 08:36:15 UTC
Thanks for the poke, a few more fixups done too.